From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
Date: Tue, 31 Oct 2023 12:22:47 +0200 [thread overview]
Message-ID: <ZUDVdyAXr8SlJlnx@smile.fi.intel.com> (raw)
In-Reply-To: <ZUAcffriaEkNcRH_@black.fi.intel.com>
On Mon, Oct 30, 2023 at 11:14:11PM +0200, Raag Jadav wrote:
> On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote:
> > iWhen ->pin_config_set() is called from the GPIO library (assumed
> > GpioIo() ACPI resource), the argument can be 1, when, for example,
> > PullDefault is provided. In such case we supply sane default in
> > the driver. Move that default assingment to a switch-case, so
> > it will be consolidated in one place.
>
> Looks good.
Thank you for review. Can you give your Rb tag then?
> iWhen -> When
I'll fix it locally.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-31 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 15:53 [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case Andy Shevchenko
2023-10-30 21:14 ` Raag Jadav
2023-10-31 10:22 ` Andy Shevchenko [this message]
2023-10-31 13:57 ` Raag Jadav
2023-11-01 6:35 ` Mika Westerberg
2023-11-01 9:34 ` Andy Shevchenko
2023-11-01 10:44 ` Mika Westerberg
2023-11-02 7:36 ` Linus Walleij
2023-11-02 12:34 ` Andy Shevchenko
2023-11-02 12:37 ` Andy Shevchenko
2023-11-02 12:56 ` Linus Walleij
2023-11-13 11:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUDVdyAXr8SlJlnx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox