From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B086BC4332F for ; Tue, 31 Oct 2023 10:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343644AbjJaKW4 (ORCPT ); Tue, 31 Oct 2023 06:22:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235954AbjJaKWy (ORCPT ); Tue, 31 Oct 2023 06:22:54 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E7D583; Tue, 31 Oct 2023 03:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698747772; x=1730283772; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VISwYifRZkoN4jWwcGitg4uU+PDhruRG2nnbbHQj4JI=; b=QlsckmpkJlr4OaomiK2xaLpSgtTh/6oK//8h8P6gQeE/PRSRJ3nar/l+ wGQDCM9sXBXaLlmMA3R2inLls7GmGX509DxeFlPbCLpjMlVWKsDFHbkEv 5xw8hYX6h9+RG6xAJpHJ+kpGlmDho1KlXFmPDEpOPJirKhPk7q7AcJBFY /Ab3WRgtshFo/ShP7szK35zVTNLV4a1LZ4A1C+GPJQvldBQphn1EQpZep /SpHultyQSBn+yYvdvKfcqN625UOsNc1uH8W16YUHb9ikYgqbwqx/STeh LX6zeaSgMom+rjQRs8Y1Q2Lpd5D0VyZcWEvzhGi6gk7jnRaqECsqEGHxs A==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="391128353" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="391128353" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 03:22:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="754097005" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="754097005" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 03:22:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qxltX-0000000A6wI-1TV6; Tue, 31 Oct 2023 12:22:47 +0200 Date: Tue, 31 Oct 2023 12:22:47 +0200 From: Andy Shevchenko To: Raag Jadav Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case Message-ID: References: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2023 at 11:14:11PM +0200, Raag Jadav wrote: > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > > iWhen ->pin_config_set() is called from the GPIO library (assumed > > GpioIo() ACPI resource), the argument can be 1, when, for example, > > PullDefault is provided. In such case we supply sane default in > > the driver. Move that default assingment to a switch-case, so > > it will be consolidated in one place. > > Looks good. Thank you for review. Can you give your Rb tag then? > iWhen -> When I'll fix it locally. -- With Best Regards, Andy Shevchenko