From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C914C4167D for ; Tue, 31 Oct 2023 10:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234970AbjJaKmQ (ORCPT ); Tue, 31 Oct 2023 06:42:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbjJaKmP (ORCPT ); Tue, 31 Oct 2023 06:42:15 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4636783; Tue, 31 Oct 2023 03:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698748933; x=1730284933; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9uZ64730+nuirrjXNVNzsndGS/0DAlcsQpQ+mk4LQFU=; b=HYnBXvPke/ccpEkT2ybMlW/FT4l5tnPAaysf7anctaQ4GNDRcXwflgPN ed2jqxzmUDCsf4HeoKXmU0fJd8O3+RV0tapd5wSrELQ/Ni5vrMLts56LA YyDMK6CPEf+aQltgUFt/xH0f0UcpQiSZyJljWQ4HxCXRom/9w7y0WkG1n wjUZ8oo29yu1wvsX5uhGykFlDSndGI4Cy/1Fgmw/ZRy2DhDbFEVpMQFL2 4WwergOel5mJjDAj+2fjx0uB0m+IgDagjAi/XinnHnSctu4kK76IEAqaB 9k8nrxmmmpxZ8Us1yutZG5IUQ/hPnoWxRb0nv8gwZlcgqca4sKyY8voI2 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="1108639" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="1108639" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 03:42:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="795536405" X-IronPort-AV: E=Sophos;i="6.03,265,1694761200"; d="scan'208";a="795536405" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 03:42:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qxmCE-0000000A7Eh-1tq2; Tue, 31 Oct 2023 12:42:06 +0200 Date: Tue, 31 Oct 2023 12:42:06 +0200 From: Andy Shevchenko To: Hangyu Hua Cc: kristo@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, tony@atomide.com, claudiu.beznea@microchip.com, robh@kernel.org, dario.binacchi@amarulasolutions.com, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ti: fix possible memory leak in _ti_omap4_clkctrl_setup() Message-ID: References: <20231031103010.23792-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231031103010.23792-1-hbh25y@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2023 at 06:30:10PM +0800, Hangyu Hua wrote: > kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform > dynamic memory allocation. So clkctrl_name needs to be freed when > provider->clkdm_name is NULL. > Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()") > Signed-off-by: Hangyu Hua > --- > > v2 and v3: fix commit info. I believe I gave you my Rb tag. It's your responsibility to care it on if you send a new version. Otherwise, please tell what makes you think that tag should not be here? -- With Best Regards, Andy Shevchenko