From: Sean Christopherson <seanjc@google.com>
To: Paul Durrant <paul@xen.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Durrant <pdurrant@amazon.com>,
David Woodhouse <dwmw@amazon.co.uk>,
David Woodhouse <dwmw2@infradead.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH v7 06/11] KVM: xen: allow shared_info to be mapped by fixed HVA
Date: Tue, 31 Oct 2023 16:52:29 -0700 [thread overview]
Message-ID: <ZUGTPZLRcHRajtYB@google.com> (raw)
In-Reply-To: <20231002095740.1472907-7-paul@xen.org>
On Mon, Oct 02, 2023, Paul Durrant wrote:
> NOTE: The change of the kvm_xen_hvm_attr shared_info from struct to union
> is technically an ABI change but it's entirely compatible with
> existing users.
It's not an ABI change, is it? Userspace that picks up the new header might generate
different code on a rebuild, but the actual ABI is unchanged, no?
> @@ -684,6 +692,14 @@ int kvm_xen_hvm_get_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
> r = 0;
> break;
>
> + case KVM_XEN_ATTR_TYPE_SHARED_INFO_HVA:
> + if (kvm->arch.xen.shinfo_cache.active)
As requested in previous patches, please explicitly check that the cache is in
the right "mode".
> + data->u.shared_info.hva = kvm_gpc_hva(&kvm->arch.xen.shinfo_cache);
> + else
> + data->u.shared_info.hva = 0;
> + r = 0;
> + break;
next prev parent reply other threads:[~2023-10-31 23:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 9:57 [PATCH v7 00/11] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-10-02 9:57 ` [PATCH v7 01/11] KVM: pfncache: add a map helper function Paul Durrant
2023-10-31 23:20 ` Sean Christopherson
2023-11-02 17:09 ` Paul Durrant
2023-10-02 9:57 ` [PATCH v7 02/11] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-10-31 23:28 ` Sean Christopherson
2023-11-02 17:52 ` Paul Durrant
2023-11-03 23:07 ` Sean Christopherson
2023-10-02 9:57 ` [PATCH v7 03/11] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-10-31 23:37 ` Sean Christopherson
2023-10-02 9:57 ` [PATCH v7 04/11] KVM: pfncache: base offset check on khva rather than gpa Paul Durrant
2023-10-31 23:40 ` Sean Christopherson
2023-11-02 18:11 ` Paul Durrant
2023-11-03 23:10 ` Sean Christopherson
2023-10-02 9:57 ` [PATCH v7 05/11] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-10-31 23:49 ` Sean Christopherson
2023-11-02 18:01 ` Paul Durrant
2023-11-03 23:12 ` Sean Christopherson
2023-10-02 9:57 ` [PATCH v7 06/11] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-10-31 23:52 ` Sean Christopherson [this message]
2023-10-02 9:57 ` [PATCH v7 07/11] KVM: xen: allow vcpu_info " Paul Durrant
2023-10-02 9:57 ` [PATCH v7 08/11] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-10-02 9:57 ` [PATCH v7 09/11] KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA Paul Durrant
2023-10-02 9:57 ` [PATCH v7 10/11] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-10-02 9:57 ` [PATCH v7 11/11] KVM: xen: allow vcpu_info content to be 'safely' copied Paul Durrant
2023-10-31 23:58 ` Sean Christopherson
2023-11-08 15:15 ` David Woodhouse
2023-11-08 20:55 ` Sean Christopherson
2023-11-08 21:56 ` David Woodhouse
2023-10-05 6:41 ` [PATCH v7 00/11] KVM: xen: update shared_info and vcpu_info handling David Woodhouse
2023-10-05 8:36 ` Paul Durrant
2023-11-09 10:02 ` David Woodhouse
2023-11-09 10:06 ` Paul Durrant
2023-10-30 12:00 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUGTPZLRcHRajtYB@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox