From: Charlie Jenkins <charlie@rivosinc.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Conor Dooley <conor@kernel.org>,
Samuel Holland <samuel.holland@sifive.com>,
David Laight <David.Laight@aculab.com>,
Xiao W Wang <xiao.w.wang@intel.com>,
Evan Green <evan@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v9 5/5] riscv: Test checksum functions
Date: Wed, 1 Nov 2023 13:12:24 -0700 [thread overview]
Message-ID: <ZUKxKFlIHcxZWVKg@ghost> (raw)
In-Reply-To: <be85f9cb-25cb-4d58-a0db-9b85af240bba@app.fastmail.com>
On Wed, Nov 01, 2023 at 08:14:07PM +0100, Arnd Bergmann wrote:
> On Wed, Nov 1, 2023, at 01:18, Charlie Jenkins wrote:
> > Add Kconfig support for riscv specific testing modules. This was created
> > to supplement lib/checksum_kunit.c, and add tests for ip_fast_csum and
> > csum_ipv6_magic.
> >
> > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > ---
> > arch/riscv/Kconfig.debug | 1 +
> > arch/riscv/lib/Kconfig.debug | 31 ++++
> > arch/riscv/lib/Makefile | 2 +
> > arch/riscv/lib/riscv_checksum_kunit.c | 330 ++++++++++++++++++++++++++++++++++
>
> I don't understand this bit, what is special about riscv here
> that prevents you from adding it to the common lib/checksum_kunit.c?
>
> Arnd
Oh, I can add it to the common one. I was hesitant to do that just
because it would affect all archs.
- Charlie
next prev parent reply other threads:[~2023-11-01 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 0:18 [PATCH v9 0/5] riscv: Add fine-tuned checksum functions Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 1/5] asm-generic: Improve csum_fold Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 2/5] riscv: Add static key for misaligned accesses Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 3/5] riscv: Checksum header Charlie Jenkins
2023-11-01 15:22 ` Jisheng Zhang
2023-11-01 17:07 ` Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 4/5] riscv: Add checksum library Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 5/5] riscv: Test checksum functions Charlie Jenkins
2023-11-01 19:14 ` Arnd Bergmann
2023-11-01 20:12 ` Charlie Jenkins [this message]
2023-11-01 11:50 ` [PATCH v9 0/5] riscv: Add fine-tuned " Conor Dooley
2023-11-01 17:06 ` Charlie Jenkins
2023-11-02 10:21 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUKxKFlIHcxZWVKg@ghost \
--to=charlie@rivosinc.com \
--cc=David.Laight@aculab.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=conor@kernel.org \
--cc=evan@rivosinc.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox