From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
Date: Thu, 2 Nov 2023 18:49:04 +0200 [thread overview]
Message-ID: <ZUPTAG5ZuxKoOugs@smile.fi.intel.com> (raw)
In-Reply-To: <34b4f396-ecf3-576d-69e5-f8eac2a5d488@redhat.com>
On Thu, Nov 02, 2023 at 04:47:41PM +0100, Hans de Goede wrote:
> On 11/2/23 16:12, Andy Shevchenko wrote:
...
> > + soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:03", "Panel SE",
> > + gpio_index - CHV_GPIO_IDX_START_SW, value);
>
> The "gpio_index - CHV_GPIO_IDX_START_SW" here needs to be "gpio_index - CHV_GPIO_IDX_START_SE".
>
> Also this patch needs s/soc_exec_opaque_gpio/soc_opaque_gpio_set_value/ to compile ...
Ah, indeed. I looks like I run the test build, but forgot to look into the result. :-(
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-02 16:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 15:12 [rft, PATCH v3 00/15] drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 01/15] drm/i915/dsi: assume BXT gpio works for non-native GPIO Andy Shevchenko
2023-11-02 17:10 ` [Intel-gfx] " Ville Syrjälä
2023-11-02 17:40 ` Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 02/15] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915 Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 03/15] drm/i915/dsi: clarify GPIO exec sequence Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 04/15] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value() Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 05/15] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 06/15] drm/i915/dsi: Replace while(1) with one with clear exit condition Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 07/15] drm/i915/dsi: Get rid of redundant 'else' Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 08/15] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 09/15] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init() Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 10/15] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_exec_gpio() Andy Shevchenko
2023-11-02 15:19 ` Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 11/15] drm/i915/dsi: Extract common soc_gpio_set_value() helper Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 12/15] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 13/15] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities Andy Shevchenko
2023-11-02 15:12 ` [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back Andy Shevchenko
2023-11-02 15:47 ` Hans de Goede
2023-11-02 16:49 ` Andy Shevchenko [this message]
2023-11-03 19:27 ` kernel test robot
2023-11-02 15:12 ` [PATCH v3 15/15] drm/i915/iosf: Drop unused APIs Andy Shevchenko
2023-11-02 15:17 ` [rft, PATCH v3 00/15] drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO Andy Shevchenko
2023-11-02 15:40 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUPTAG5ZuxKoOugs@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox