From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA14C4167D for ; Fri, 3 Nov 2023 16:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376468AbjKCQ0z (ORCPT ); Fri, 3 Nov 2023 12:26:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345684AbjKCQ0s (ORCPT ); Fri, 3 Nov 2023 12:26:48 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD3DD6B; Fri, 3 Nov 2023 09:26:28 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1cc34c3420bso23675345ad.3; Fri, 03 Nov 2023 09:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699028788; x=1699633588; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=6RxeQm4cmA2JrbAVa8HTs83GsMijucDFIF/Igdee3yE=; b=W7agCHmw8Wf8ksBG+oocMABlvXfmAtkin1FM2uDvC0/DWJzQYT5/CSJ8YToJorGPoD pbK/6MIe60aD0nKfJPmgkmyOQH+GIsNZI9FKW4zYX/YOxVGBowL+eIMrBKRtEgfS1G5D O3/QIWe8MzvHBnpC2MXu7FvnHF94+DtgunW9les5SDXRrj8V1I4EYQTW0FBuZqzmV3S0 Fib3DUmFjnHokYxQm3cgt+NyY2rG6JbpMWDXnelH+I/GV2PeFIV7wFnZcXEK6EAzyZc4 6/6TbYJbnwep3+1nU0PzVTG8PGcPYfcT0FkN97LmPU+RNmH8vMpnGQtWY0MszKGbs2Ao 0A5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699028788; x=1699633588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6RxeQm4cmA2JrbAVa8HTs83GsMijucDFIF/Igdee3yE=; b=G5tXNGIfFrhMj7Gs1tds4L8d7YH1FrWvSK26NDF84/evFVebXOr9E45XPKtZNBiM25 EzTnwzw9JLOlGKOxQ55WPdzN4JQvUx7LnTHjVux00J4fC/NK4yR/kAhh71jztMTB16/A leJClUTNS7wUMdzsB+WGFYtvOV1/zalwrRchyRefmM3tIJ9WMIHhlZDBdpxvKvOd0fR5 y9qaQe3HojnGzm5cRuXOav4BEHVH5r71uA0NopcdnXP2jHsnpbDpaCfWSqCGAXUVddLq aDtyfdGAABg6bOk1PI/+c5S6HJekLm1gVrmJfCQrGwMExNRVnkYUui45gTAfnWshFpYa sRcQ== X-Gm-Message-State: AOJu0YxTS42aymXh3oUsy9wvgTxZfhAHZM3HR35hHjEInxW006h9zmmO wq8ZrsUk3GPIQ6pGxui4ijc= X-Google-Smtp-Source: AGHT+IH+UfkDk1M09a11MgKdQ/HzVeEoAf8yilhUhOvIPnSu6kULsuDKgmMoS0l4cwRyk9qiS6Zxpw== X-Received: by 2002:a17:902:f551:b0:1cc:5b2a:2f33 with SMTP id h17-20020a170902f55100b001cc5b2a2f33mr14887406plf.43.1699028787560; Fri, 03 Nov 2023 09:26:27 -0700 (PDT) Received: from debian (c-71-202-158-162.hsd1.ca.comcast.net. [71.202.158.162]) by smtp.gmail.com with ESMTPSA id p22-20020a170902b09600b001b8a3e2c241sm1609244plr.14.2023.11.03.09.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 09:26:27 -0700 (PDT) From: fan X-Google-Original-From: fan Date: Fri, 3 Nov 2023 09:26:06 -0700 To: Vishal Verma Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer Subject: Re: [PATCH v8 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource() Message-ID: References: <20231101-vv-kmem_memmap-v8-0-5e4a83331388@intel.com> <20231101-vv-kmem_memmap-v8-1-5e4a83331388@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231101-vv-kmem_memmap-v8-1-5e4a83331388@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 01, 2023 at 04:51:51PM -0600, Vishal Verma wrote: > A review of the memmap_on_memory modifications to add_memory_resource() > revealed an instance of an open-coded kmemdup(). Replace it with > kmemdup(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- Reviewed-by: Fan Ni > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..6be7de9efa55 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1439,11 +1439,11 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > - params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > + params.altmap = kmemdup(&mhp_altmap, > + sizeof(struct vmem_altmap), > + GFP_KERNEL); > if (!params.altmap) > goto error; > - > - memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); > } > /* fallback to not using altmap */ > } > > -- > 2.41.0 >