From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1329C4167D for ; Sun, 5 Nov 2023 10:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbjKEKhE (ORCPT ); Sun, 5 Nov 2023 05:37:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjKEKhC (ORCPT ); Sun, 5 Nov 2023 05:37:02 -0500 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 390E3A2; Sun, 5 Nov 2023 02:37:00 -0800 (PST) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 3A5AasM4002738; Sun, 5 Nov 2023 11:36:54 +0100 Date: Sun, 5 Nov 2023 11:36:54 +0100 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , Zhangjin Wu , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/6] tools/nolibc: error out on unsupported architecture Message-ID: References: <20231105-nolibc-mips-be-v1-0-6c2ad3e50a1f@weissschuh.net> <20231105-nolibc-mips-be-v1-1-6c2ad3e50a1f@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231105-nolibc-mips-be-v1-1-6c2ad3e50a1f@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 05, 2023 at 11:09:55AM +0100, Thomas Weißschuh wrote: > When an architecture is unsupported arch.h would silently continue. > This leads to a lot of followup errors because my_syscallX() is not > defined and the startup code is missing. > > Avoid these confusing errors and fail the build early with a clear > error message and location. Oops, good catch! Thanks, Willy