From: James Seo <james@equiv.tech>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Lukasz Stelmach <l.stelmach@samsung.com>,
Armin Wolf <W_Armin@gmx.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] hwmon: (hp-wmi-sensors) Fix failure to load on EliteDesk 800 G6
Date: Sun, 5 Nov 2023 10:51:00 -0800 [thread overview]
Message-ID: <ZUfkFHmrlnL7gbfG@equiv.tech> (raw)
In-Reply-To: <2b48b41d-7d82-470a-a40e-c8f3c9de94dd@roeck-us.net>
On Sat, Nov 04, 2023 at 09:29:43AM -0700, Guenter Roeck wrote:
> On 11/4/23 09:07, James Seo wrote:
>>
>> #define HP_WMI_WSTR_INFO(name, wids) { \
>> .matches = { \
>> DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), \
>> DMI_EXACT_MATCH(DMI_BOARD_NAME, (name)), \
>> }, \
>> .driver_data = (void *)(wids), \
>> }
>>
>
> Quite frankly, I dislike multi-line macros because they make it (more)
> difficult to understand the code. If that is where you want to go,
> I'd rather keep the current code (or wait until someone else maintains
> the hwmon subsystem).
OK, I'll remove that macro if I end up using a DMI table for this.
>> Out of curiosity, how would you feel about just adding full raw WMI string
>> support now? It wouldn't take much more work and for various small reasons
>> it's starting to look like a better idea to me.
>>
>
> I don't know; I would have to see the code.
I'll submit something in a bit.
prev parent reply other threads:[~2023-11-05 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 18:19 [RFC] hwmon: (hp-wmi-sensors) Fix failure to load on EliteDesk 800 G6 James Seo
2023-11-03 19:36 ` Guenter Roeck
2023-11-04 16:07 ` James Seo
2023-11-04 16:29 ` Guenter Roeck
2023-11-05 18:51 ` James Seo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUfkFHmrlnL7gbfG@equiv.tech \
--to=james@equiv.tech \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=l.stelmach@samsung.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox