public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	Hunter Chasens <hunter.chasens18@ncf.edu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linux Documentation <linux-doc@vger.kernel.org>,
	Linux DRI Development <dri-devel@lists.freedesktop.org>,
	amd-gfx@lists.freedesktop.org, daniel@ffwll.ch,
	airlied@gmail.com, Xinhui.Pan@amd.com, christian.koenig@amd.com,
	alexander.deucher@amd.com, evan.quan@amd.com,
	Lijo Lazar <lijo.lazar@amd.com>
Subject: Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning
Date: Mon, 6 Nov 2023 15:14:38 +0700	[thread overview]
Message-ID: <ZUigbshGGc451V5L@debian.me> (raw)
In-Reply-To: <665794d7-38e0-4e74-9af7-eca986792e44@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote:
> 
> 
> On 11/5/23 21:15, Bagas Sanjaya wrote:
> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote:
> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> >> index 517b9fb4624c..703fe2542258 100644
> >> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> >> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> >> @@ -990,11 +990,14 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> >>   * the power state and the clock information for those levels. If deep sleep is
> >>   * applied to a clock, the level will be denoted by a special level 'S:'
> >>   * E.g.,
> >> - *	S: 19Mhz *
> >> - *	0: 615Mhz
> >> - *	1: 800Mhz
> >> - *	2: 888Mhz
> >> - *	3: 1000Mhz
> >> + *
> >> + * ::
> >> + *
> >> + *  S: 19Mhz *
> >> + *  0: 615Mhz
> >> + *  1: 800Mhz
> >> + *  2: 888Mhz
> >> + *  3: 1000Mhz
> >>   *
> >>   *
> >>   * To manually adjust these states, first select manual using
> > 
> > LGTM, thanks!
> > 
> > Fixes: 615585d09b33 ("Documentation/amdgpu: Modify pp_dpm_*clk details")
> > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > 
> 
> but can it be done without being so obvious about using Sphinx (or is it ReST?)
> in source files?

Yes, the comment is included in Documentation/gpu/amdgpu/thermal.rst, so reST
syntax applies there.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-11-06  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-05 21:00 [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning Hunter Chasens
2023-11-06  5:15 ` Bagas Sanjaya
2023-11-06  5:26   ` Randy Dunlap
2023-11-06  8:14     ` Bagas Sanjaya [this message]
2023-11-06 10:15       ` Jani Nikula
2023-11-06 19:06         ` Hunter Chasens
2023-11-06 19:50           ` Randy Dunlap
2023-11-06 11:36 ` Lazar, Lijo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUigbshGGc451V5L@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    --cc=hunter.chasens18@ncf.edu \
    --cc=lijo.lazar@amd.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox