From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D35C4332F for ; Wed, 8 Nov 2023 10:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344216AbjKHKPF (ORCPT ); Wed, 8 Nov 2023 05:15:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235492AbjKHKPD (ORCPT ); Wed, 8 Nov 2023 05:15:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E44CD1725 for ; Wed, 8 Nov 2023 02:15:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BDA2C433C7; Wed, 8 Nov 2023 10:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699438501; bh=Hj9x40ONDh0+AM7KopE8lAFnZbwCDvSvfpHcxcASXx8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+DiYp9s/DKY59q2XlZb+/4AjuCNbgCe2J32meUOFyNd6QV+wkK6kvzO17mPZKcb4 rdmrWStdMqoHVjhnXHqoDzDcRaUIgrIMSFnKKELWxMCsEQ0q+ZMI/JiGkUNIC+blJY ZcXJqkxa+mhikgNEJ4+ZYbBCQIeTewnAiAJWj/bzXsykWglLyy49gqKunxD5MzMXxo SVM5cHQ5ctCVu04RgXddQVi/TGgMMp83yluwteAFrFSb6oXvtZ3/7zvikhY1PQ4m/O 68BokM1gmdamwDSWyK76HAv02PZZdd5tENnnBg1MlKKyOIWWT2l+NsFMX4V7/Ru775 vR839Q0UJyXRg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1r0fbE-0007D6-23; Wed, 08 Nov 2023 11:15:52 +0100 Date: Wed, 8 Nov 2023 11:15:52 +0100 From: Johan Hovold To: Victor Fragoso Cc: "larsm17@gmail.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] USB: serial: option: add Fibocom L7xx modules Message-ID: References: <9315051ae981aaad1d46724641defc6e5f79d12b.camel@hotmail.com> <84a78bb8-fd85-4ee5-9c92-859e8450a587@gmail.com> <94477736e69cc76eaaef8584d7e1aa5078a0611e.camel@hotmail.com> <103aa944-073a-4dd0-8d58-8c9123dc2352@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2023 at 10:02:28PM +0000, Victor Fragoso wrote: > On Sat, 2023-10-28 at 02:59 +0700, Lars Melin wrote: > > Johan may have a different opinion from mine and he is the one to > > decide, my take is that there is no value in having a minor part of the > > list grouped by mfgr and the major part of the list sorted by USB Id. > > We have also seen in the past that when a mfgr1 buys a chipset from > > mfgr2 and then sells his product with mfgr2 Id instead of using one of > > his own Id's then there is also not uncommon that mfgr3 is also buying > > the same chipset without changing Id. Hence "Manufacturer name" is not > > unique but the vid is.. > > > > The list should not be seen or used as a cross reference between > > mfgr:product name and vid:pid, anyone who needs to search the driver > > source to see if a device is supported ought to know its vid:pid so can > > search on those and that works much better if the list is sorted by > > vid:pid in ascending order. Personally I'd rather see a source without > > all the unnecessary defines, only vid:pid based and with the > > mfgr/product as an optional comment. > > > > When adding Id's to the driver it is you who should know the devices you > > are adding, don't add Id's if you have not personally confirmed their > > interface composition and usage. > > Those who told you add these Id's apparently also told you that there > > are two versions of 2cb7:0001, one with ECM interfaces and one with > > RNDIS interfaces but your usb-devices output show both to be identical.. > > There is no RNDIS interface in your listings, both of them will load > > the cdc_ether driver. > Lars, understood. Your point makes sense and I could accept it with no > problems. > > Johan, can you please share your opinion to decide? I fully agree with Lars here. > 1- Should I create a new commit inserting the PID grouped among to > Fibocom's VID? Or separately on Fibocom's VID section and another one > on ZTE's VID section? So as Lars suggested, try to keep the list sorted by VID / PID (i.e. split them up). > 2- Should I remove the generic Fibocom product comment and add just the > product/mode that I could test it? e.g. Fibocom L716-EU (ECM) Yes, please do that. Johan