From: Catalin Marinas <catalin.marinas@arm.com>
To: Huang Shijie <shijie@os.amperecomputing.com>
Cc: will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org,
arnd@arndb.de, mark.rutland@arm.com, broonie@kernel.org,
keescook@chromium.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
patches@amperecomputing.com
Subject: Re: [PATCH v3] arm64: irq: set the correct node for VMAP stack
Date: Thu, 23 Nov 2023 16:55:31 +0000 [thread overview]
Message-ID: <ZV-EA46rBJ9WK4UH@arm.com> (raw)
In-Reply-To: <20231118160205.3923-1-shijie@os.amperecomputing.com>
On Sun, Nov 19, 2023 at 12:02:05AM +0800, Huang Shijie wrote:
> diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c
> index eaa31e567d1e..90519d981471 100644
> --- a/drivers/base/arch_numa.c
> +++ b/drivers/base/arch_numa.c
> @@ -144,7 +144,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid)
> unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;
> EXPORT_SYMBOL(__per_cpu_offset);
>
> -static int __init early_cpu_to_node(int cpu)
> +int early_cpu_to_node(int cpu)
> {
> return cpu_to_node_map[cpu];
> }
I don't think we need this change, let's make the arm64
init_irq_stacks() an __init function instead.
> diff --git a/include/asm-generic/numa.h b/include/asm-generic/numa.h
> index 1a3ad6d29833..16073111bffc 100644
> --- a/include/asm-generic/numa.h
> +++ b/include/asm-generic/numa.h
> @@ -35,6 +35,7 @@ int __init numa_add_memblk(int nodeid, u64 start, u64 end);
> void __init numa_set_distance(int from, int to, int distance);
> void __init numa_free_distance(void);
> void __init early_map_cpu_to_node(unsigned int cpu, int nid);
> +int early_cpu_to_node(int cpu);
And add __init here.
With these changes:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Happy to take this patch through the arm64 tree if I get an ack from
Greg or Rafael on the drivers/* change.
next prev parent reply other threads:[~2023-11-23 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:16 [PATCH] arm64: irq: set the correct node for VMAP stack Huang Shijie
2023-11-15 14:50 ` kernel test robot
2023-11-16 17:18 ` Catalin Marinas
2023-11-17 2:50 ` Shijie Huang
2023-11-18 15:47 ` [PATCH v2] " Huang Shijie
2023-11-18 16:02 ` [PATCH v3] " Huang Shijie
2023-11-23 16:55 ` Catalin Marinas [this message]
2023-11-24 3:15 ` [PATCH v4] " Huang Shijie
2023-11-24 11:47 ` Catalin Marinas
2023-12-05 15:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV-EA46rBJ9WK4UH@arm.com \
--to=catalin.marinas@arm.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@amperecomputing.com \
--cc=rafael@kernel.org \
--cc=shijie@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox