Re: [net-next PATCH] net: phy: aquantia: drop wrong endianness conversion for addr and CRC

Jakub Kicinski
2023-11-22T18:23:54Z

On Wed, 22 Nov 2023 18:53:39 +0100 Christian Marangi wrote:
> So they DO get converted to the HOST endian on reading the firmware from
> an nvmem cell or a filesystem?

They don't get converted when "reading from nvmem / fs".
They get converted when you do:

word = get_unaligned((const u32 *)(data + pos));

get_unaligned() is basically:

#if BIGENDIAN
#define get_unaligned get_unaligned_be32
#else
#define get_unaligned get_unaligned_le32
#endif

so you'll get different behavior here depending on the CPU.