From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E64C61D9B for ; Wed, 22 Nov 2023 15:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344537AbjKVPg1 (ORCPT ); Wed, 22 Nov 2023 10:36:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344517AbjKVPf7 (ORCPT ); Wed, 22 Nov 2023 10:35:59 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 112622D57; Wed, 22 Nov 2023 07:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700667290; x=1732203290; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fOjYqo3PT8YGwRzKUAvwr8hmWkL6CCqgBph732SCw5k=; b=MpSjPO6Rb1tqOTZ4TdzEi2v4R5QnrKZYpnHK28FowPNg2PF4TLRfq4Fu GESPyqF8hGrvQUaMfhbYvbQJv+Bx0JDK6iBc5kB29IIDGL6Wxb0YzkqJ8 tdjSGFDjfrDrNvCpeRM2s/8quuQ58nJFTRJwMzYvh4s8nv2wfQMWtHb8i rB0FEnsENNWaRolbeT5ah+XO5cdWC3wFonlqrnNICxWSTC+bpvzr47r5v PtURuvYGxBE9xxolblhru0ILATuBbyLVrP2TVxK6NtJt+1ZVA26rg+MAS h8eXrsRrvVlHA6nmKi2/nH0Ixzpgbv1sZnP2bBngskCBBVeREzG1jfEMp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="396000879" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="396000879" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 07:34:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="884658912" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="884658912" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 07:34:37 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5pFL-0000000G85G-0H85; Wed, 22 Nov 2023 17:34:35 +0200 Date: Wed, 22 Nov 2023 17:34:34 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij Subject: Re: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Message-ID: References: <20231120193353.1670732-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2023 at 07:15:33PM +0200, Andy Shevchenko wrote: > On Tue, Nov 21, 2023 at 08:14:09AM +0100, Krzysztof Kozlowski wrote: > > On 20/11/2023 20:26, Andy Shevchenko wrote: > > > The group is not used anywhere, remove it. And if needed, it should be > > > struct pingroup anyway. > > > > > > While at it, replace kernel.h with what exactly being used. > > > > Missing Reported-by and Closes by for LKP... Unless you discovered it > > without its report? > > It's just at hand discovery. > > > Missing sm8550. > > And sm8650, but there LPI_FUNCTION(gpio) and I'm wondering why LKP complains > about it. It's really a maze to me. Ah, this is _pins, _groups is still in use. Okay, I will remove that in next version. > > > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ > > > { \ > > > - .group.name = "gpio" #id, \ > > > - .group.pins = gpio##id##_pins, \ > > > > Aren't these used by core pinctrl code? > > Only via APIs and pin control registered them also via APIs, so I don't think > this is being used directly. But if you see how, tell me! I spent already a few > hours on this and haven't got any clear picture in my mind. -- With Best Regards, Andy Shevchenko