From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A713C61D97 for ; Wed, 22 Nov 2023 19:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbjKVTyV (ORCPT ); Wed, 22 Nov 2023 14:54:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbjKVTyU (ORCPT ); Wed, 22 Nov 2023 14:54:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 257FF18E for ; Wed, 22 Nov 2023 11:54:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 786A1C433C7; Wed, 22 Nov 2023 19:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700682856; bh=zRXHgQP88VauegiSbHXFvskpTZuZ3/Jyf1lcUiA8WAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mrNG99+mNALbVJhcW1vZYsOwvFPrCrTvA/jh7hRpd+LcpAjrWl05+dsKNccSbPsQl CLw7RDjB0YX0WiVhHbqf4bY9sED1Rdv/BrMc8ZrGKZ5/BLGHHvd20AZO2c0TAHDJ8/ UIEsJBiFfOmx7vSiQzWUEMb1af9hnvTsLwmFPMzoJZVyDpEAz00YfkUslW/9lK6sx+ w1utbiS0AeRY7ZD+z8iRjs28Gdo/91ZkODeVDhByD7rdvYxm4uzW1S1FJxUq9i27h1 GY17Su7N4FztAwiZgXMRDkO+eDd7QrVLu3b9aC4GNwIsYnFVZUOWHLbkaF/UDnTO2G 8WLRqznC+zHrw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 71AA640094; Wed, 22 Nov 2023 16:54:13 -0300 (-03) Date: Wed, 22 Nov 2023 16:54:13 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Peter Zijlstra , Ian Rogers , Adrian Hunter , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Linus Torvalds , Stephane Eranian , Masami Hiramatsu , Andi Kleen , linux-trace-devel@vger.kernel.org, linux-toolchains@vger.kernel.org Subject: Re: [PATCH 18/52] perf report: Add 'type' sort key Message-ID: References: <20231110000012.3538610-1-namhyung@kernel.org> <20231110000012.3538610-19-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Nov 22, 2023 at 10:49:13AM -0800, Namhyung Kim escreveu: > On Tue, Nov 21, 2023 at 9:55 AM Arnaldo Carvalho de Melo wrote: > > ⬢[acme@toolbox perf-tools-next]$ perf report -s type > > perf: Segmentation fault > > -------- backtrace -------- > > perf[0x69f743] > > /lib64/libc.so.6(+0x3dbb0)[0x7f89b4778bb0] > > perf[0x505af6] > > perf[0x504f01] > > /lib64/libc.so.6(+0x27b8a)[0x7f89b4762b8a] > > /lib64/libc.so.6(__libc_start_main+0x8b)[0x7f89b4762c4b] > > perf[0x40ed65] > > ⬢[acme@toolbox perf-tools-next]$ > > Right, the 'type' sort key was added here but unfortunately > it's not ready for prime time yet. It also needs the next patch > 19/52 ("perf report: Support data type profiling") to fully enable > the feature. Do you think it's better to squash into here? I haven't checked if squashing would be a good idea, but if you think its the right granularity, then do it, as long as we can test features in various ways as they are getting added, as I did, using a random perf.data file. - Arnaldo