* [PATCH] ipmi: Use regspacings passed as a module parameter
@ 2023-11-22 20:34 Emilio Perez
2023-11-22 20:49 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Emilio Perez @ 2023-11-22 20:34 UTC (permalink / raw)
To: minyard; +Cc: Emilio Perez, moderated list:IPMI SUBSYSTEM, open list
regspacings parameter is currently ignored and the platform data uses a
default value of 0, this has been fixed by setting the appropriate field
in the platform data.
Fixes: 3cd83bac481d ("ipmi: Consolidate the adding of platform devices")
Signed-off-by: Emilio Perez <emiliopeju@gmail.com>
---
drivers/char/ipmi/ipmi_si_hardcode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_si_hardcode.c b/drivers/char/ipmi/ipmi_si_hardcode.c
index ed5e91b1e040..0c92fa3eee88 100644
--- a/drivers/char/ipmi/ipmi_si_hardcode.c
+++ b/drivers/char/ipmi/ipmi_si_hardcode.c
@@ -80,10 +80,10 @@ static void __init ipmi_hardcode_init_one(const char *si_type_str,
}
p.regsize = regsizes[i];
+ p.regspacing = regspacings[i];
p.slave_addr = slave_addrs[i];
p.addr_source = SI_HARDCODED;
p.regshift = regshifts[i];
- p.regsize = regsizes[i];
p.addr = addr;
p.space = addr_space;
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: Use regspacings passed as a module parameter
2023-11-22 20:34 [PATCH] ipmi: Use regspacings passed as a module parameter Emilio Perez
@ 2023-11-22 20:49 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2023-11-22 20:49 UTC (permalink / raw)
To: Emilio Perez; +Cc: moderated list:IPMI SUBSYSTEM, open list
On Wed, Nov 22, 2023 at 08:34:28PM +0000, Emilio Perez wrote:
> regspacings parameter is currently ignored and the platform data uses a
> default value of 0, this has been fixed by setting the appropriate field
> in the platform data.
Yep, queued for next release. Thank you.
-corey
>
> Fixes: 3cd83bac481d ("ipmi: Consolidate the adding of platform devices")
> Signed-off-by: Emilio Perez <emiliopeju@gmail.com>
> ---
> drivers/char/ipmi/ipmi_si_hardcode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_hardcode.c b/drivers/char/ipmi/ipmi_si_hardcode.c
> index ed5e91b1e040..0c92fa3eee88 100644
> --- a/drivers/char/ipmi/ipmi_si_hardcode.c
> +++ b/drivers/char/ipmi/ipmi_si_hardcode.c
> @@ -80,10 +80,10 @@ static void __init ipmi_hardcode_init_one(const char *si_type_str,
> }
>
> p.regsize = regsizes[i];
> + p.regspacing = regspacings[i];
> p.slave_addr = slave_addrs[i];
> p.addr_source = SI_HARDCODED;
> p.regshift = regshifts[i];
> - p.regsize = regsizes[i];
> p.addr = addr;
> p.space = addr_space;
>
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-22 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 20:34 [PATCH] ipmi: Use regspacings passed as a module parameter Emilio Perez
2023-11-22 20:49 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox