From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0057C5AD4C for ; Thu, 23 Nov 2023 13:40:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345569AbjKWNkg (ORCPT ); Thu, 23 Nov 2023 08:40:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345589AbjKWNkZ (ORCPT ); Thu, 23 Nov 2023 08:40:25 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 560D510EC for ; Thu, 23 Nov 2023 05:40:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3BDDC433C8; Thu, 23 Nov 2023 13:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700746829; bh=4/3MFKcSnNzFxXpwdTahwPqZj1DbgJoJ7bLgc5su8HI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E0pEvxvwR7cPb6GEgqdMm3JUCtR3QEhvZZ62nN9kkwaFO0hoPEXeWh8O11XgxoUXC LJNFXhV9g13IanBMELMe/9XENgNAYOkf/gWR1HCpN6yrW7QL0qAo0ytrJJnE+3JkLj w2eO3eN4zLXCIT2HqPaYW+bGLkIgnyuCE6npWxS1d9iI5vAJkhoNDKZynfeejpoD7q Am+/UYj9YEZiT6qesCZ+GSmA6/HAi8R8J+qKzYVodPag6MDfd/n5+nniihQ+jxWSPo s69Llhy++rs+NdjnVyLssmEltR1eJ+tKpzf3MsiqCqFdIGArRRxhtle6MNXv0LFovx y30es4PLZDpXg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EDCD940094; Thu, 23 Nov 2023 10:40:25 -0300 (-03) Date: Thu, 23 Nov 2023 10:40:25 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Peter Zijlstra , Ian Rogers , Adrian Hunter , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Linus Torvalds , Stephane Eranian , Masami Hiramatsu , Andi Kleen , linux-trace-devel@vger.kernel.org, linux-toolchains@vger.kernel.org Subject: Re: [PATCH 18/52] perf report: Add 'type' sort key Message-ID: References: <20231110000012.3538610-1-namhyung@kernel.org> <20231110000012.3538610-19-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Nov 22, 2023 at 01:13:04PM -0800, Namhyung Kim escreveu: > On Wed, Nov 22, 2023 at 11:54 AM Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 22, 2023 at 10:49:13AM -0800, Namhyung Kim escreveu: > > > On Tue, Nov 21, 2023 at 9:55 AM Arnaldo Carvalho de Melo wrote: > > > > ⬢[acme@toolbox perf-tools-next]$ perf report -s type > > > > perf: Segmentation fault > > > Right, the 'type' sort key was added here but unfortunately > > > it's not ready for prime time yet. It also needs the next patch > > > 19/52 ("perf report: Support data type profiling") to fully enable > > > the feature. Do you think it's better to squash into here? > > I haven't checked if squashing would be a good idea, but if you think > > its the right granularity, then do it, as long as we can test features > > in various ways as they are getting added, as I did, using a random > > perf.data file. > I still think it's better to split the change as it's logically separate. The smaller the patches, the better, I'd say in general. > But it's prematurely exposed then maybe needs some protection. Yeah, that is what I felt like it needed, make it more robust by checking if the used fields were properly initialized, etc. - Arnaldo