From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13664C61DF7 for ; Thu, 23 Nov 2023 14:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345797AbjKWOb0 (ORCPT ); Thu, 23 Nov 2023 09:31:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345772AbjKWObW (ORCPT ); Thu, 23 Nov 2023 09:31:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2D119E for ; Thu, 23 Nov 2023 06:31:29 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02F5DC433C7; Thu, 23 Nov 2023 14:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700749889; bh=c7OkPUznAAchcebEgWWplu2JA5cYUW6AoggSDeYEnUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=isIs17Dtqp+pc98n2d7ijWAn8hxjijg6LS2cnd/eWW9B8UNaPtGFGa6wDyi0dNoes 7rOXhM7yybPW2CXmIEPrz8ObL1t+vsePn7hxo9E28d/YyNKZ77xw1bfQr7FA6xp/9u kF6KtDK6Lrm9K8/HZ+ryF/d6Jpw8BiFyXFoOqN8r8C0PZutmntxd4tOneh7NHCWlQx VdLkH8qSot+BuMJW95lVx3/Pxm8AL3X3f0F7d9haY8QPu+5MPGM4Ry4UKYBP3O+dk4 ntKROYy9XQVsAxPC1bTx1Fa5wioCTYUkqRpakuLEXW72iXAnChWem++lHhBy+Fbr9B 7LOp9sts+vIxg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7F73040094; Thu, 23 Nov 2023 11:31:26 -0300 (-03) Date: Thu, 23 Nov 2023 11:31:26 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mike Leach , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present Message-ID: References: <20230901133716.677499-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Sep 03, 2023 at 08:36:35PM -0700, Ian Rogers escreveu: > On Fri, Sep 1, 2023 at 6:37 AM James Clark wrote: > > > > Since commit d927ef5004ef ("perf cs-etm: Add exception level consistency > > check"), the exception that was added to Perf will be triggered unless > > the following bugfix from OpenCSD is present: > > > > - _Version 1.2.1_: > > - __Bugfix__: > > ETM4x / ETE - output of context elements to client can in some > > circumstances be delayed until after subsequent atoms have been > > processed leading to incorrect memory decode access via the client > > callbacks. Fixed to flush context elements immediately they are > > committed. > > > > Rather than remove the assert and silently fail, just increase the > > minimum version requirement to avoid hard to debug issues and > > regressions. > > > > Signed-off-by: James Clark > > Reviewed-by: Ian Rogers Thanks, applied to perf-tools-next. - Arnaldo