From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35259C61DF7 for ; Thu, 23 Nov 2023 14:32:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345803AbjKWOcF (ORCPT ); Thu, 23 Nov 2023 09:32:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345798AbjKWOcD (ORCPT ); Thu, 23 Nov 2023 09:32:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F921BD for ; Thu, 23 Nov 2023 06:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700749928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7yzx9qOvDK5HqVyciE7l1diyIFw6Eysuxf8uBBLbzRo=; b=UJdEFDI+CsZ132rvGb9v8vU2o9C19aroTpRysBZORsQdpHmF2gIUGaQQDJzcohnCU4TB7G 4Y+JYfGqmrafSb20hMRD08ccAeeqWpEz7mBFT4du0fuQrG8g52u+Nykc+JXIai7RkqLekI NZ780x6mwMflGipsKV3MvgICNIiKNe8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-_SGWWHWgMVObeNhXt_Ynzw-1; Thu, 23 Nov 2023 09:32:03 -0500 X-MC-Unique: _SGWWHWgMVObeNhXt_Ynzw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B69673C0BE39; Thu, 23 Nov 2023 14:32:02 +0000 (UTC) Received: from localhost (unknown [10.72.112.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14ACC5028; Thu, 23 Nov 2023 14:32:01 +0000 (UTC) Date: Thu, 23 Nov 2023 22:31:59 +0800 From: Baoquan He To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, akpm@linux-foundation.org, ignat@cloudflare.com, eric_devolder@yahoo.com Subject: Re: [PATCH 3/3] s390/Kconfig: drop select of KEXEC Message-ID: References: <20231123073652.507034-1-bhe@redhat.com> <20231123073652.507034-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/23 at 02:43pm, Alexander Gordeev wrote: > On Thu, Nov 23, 2023 at 03:36:52PM +0800, Baoquan He wrote: > > Hi Baoquan, > > > No proof is found to require that S390 architecture has to select > > KEXEC. At least from my testing at below, dropping select of KEXEC won't > > impact anything. > > It does impact the outcome of defconfigs. > Namely, CONFIG_KEXEC is not set with this patch. Right, CONFIG_KEXEC won't be set defaultly with this patch applied. > > > ===testing 1=== > > CONFIG_CRASH_CORE=y > > CONFIG_KEXEC_CORE=y > > CONFIG_CRASH_DUMP=y > > === > > > > ===testing 2=== > > CONFIG_CRASH_CORE=y > > CONFIG_KEXEC_CORE=y > > CONFIG_KEXEC_FILE=y > > CONFIG_CRASH_DUMP=y > > === > > Unfortunately, I do not quite realize what these testings were > and what is the difference between the two. Both these two testings have CONFIG_KEXEC=n, and building all passed. I wound't present their difference, but two cases where no CONFIG_KEXEC is set and no dependency on CONFIG_KEXEC is seen. > > > So drop the select of KEXEC now. > > I suggest dropping this patch. Once the previous two are upstream > we would remove 'select KEXEC' from Kconfig together with defconfig > updates. I see your concern, will drop this one in v2. Thanks for checking these. > > > Signed-off-by: Baoquan He > > --- > > arch/s390/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > > index 3bec98d20283..1aec2e692dca 100644 > > --- a/arch/s390/Kconfig > > +++ b/arch/s390/Kconfig > > @@ -217,7 +217,6 @@ config S390 > > select HAVE_VIRT_CPU_ACCOUNTING_IDLE > > select IOMMU_HELPER if PCI > > select IOMMU_SUPPORT if PCI > > - select KEXEC > > select MMU_GATHER_MERGE_VMAS > > select MMU_GATHER_NO_GATHER > > select MMU_GATHER_RCU_TABLE_FREE > > -- > > Thanks! >