* [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase
@ 2023-11-13 2:32 Samuel Holland
2023-11-13 7:50 ` Peter Korsgaard
2023-11-13 17:45 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Holland @ 2023-11-13 2:32 UTC (permalink / raw)
To: Peter Korsgaard, Andrew Lunn
Cc: Samuel Holland, Andi Shyti, linux-i2c, linux-kernel
When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
the regmap-irq code must be able to perform I2C transactions during
suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
be suspended/resumed during the NOIRQ phase.
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
Changes in v2:
- Rebase on v6.7-rc1
drivers/i2c/busses/i2c-ocores.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 041a76f71a49..e106af83cef4 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -771,8 +771,8 @@ static int ocores_i2c_resume(struct device *dev)
return ocores_init(dev, i2c);
}
-static DEFINE_SIMPLE_DEV_PM_OPS(ocores_i2c_pm,
- ocores_i2c_suspend, ocores_i2c_resume);
+static DEFINE_NOIRQ_DEV_PM_OPS(ocores_i2c_pm,
+ ocores_i2c_suspend, ocores_i2c_resume);
static struct platform_driver ocores_i2c_driver = {
.probe = ocores_i2c_probe,
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase
2023-11-13 2:32 [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase Samuel Holland
@ 2023-11-13 7:50 ` Peter Korsgaard
2023-11-13 17:45 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-11-13 7:50 UTC (permalink / raw)
To: Samuel Holland; +Cc: Andrew Lunn, Andi Shyti, linux-i2c, linux-kernel
>>>>> "Samuel" == Samuel Holland <samuel.holland@sifive.com> writes:
> When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> the regmap-irq code must be able to perform I2C transactions during
> suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> be suspended/resumed during the NOIRQ phase.
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Changes in v2:
> - Rebase on v6.7-rc1
> drivers/i2c/busses/i2c-ocores.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index 041a76f71a49..e106af83cef4 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -771,8 +771,8 @@ static int ocores_i2c_resume(struct device *dev)
> return ocores_init(dev, i2c);
> }
> -static DEFINE_SIMPLE_DEV_PM_OPS(ocores_i2c_pm,
> - ocores_i2c_suspend, ocores_i2c_resume);
> +static DEFINE_NOIRQ_DEV_PM_OPS(ocores_i2c_pm,
> + ocores_i2c_suspend, ocores_i2c_resume);
> static struct platform_driver ocores_i2c_driver = {
> .probe = ocores_i2c_probe,
> --
> 2.42.0
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase
2023-11-13 2:32 [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase Samuel Holland
2023-11-13 7:50 ` Peter Korsgaard
@ 2023-11-13 17:45 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2023-11-13 17:45 UTC (permalink / raw)
To: Samuel Holland
Cc: Peter Korsgaard, Andrew Lunn, Andi Shyti, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Sun, Nov 12, 2023 at 06:32:45PM -0800, Samuel Holland wrote:
> When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> the regmap-irq code must be able to perform I2C transactions during
> suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> be suspended/resumed during the NOIRQ phase.
>
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-13 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 2:32 [PATCH v2] i2c: ocores: Move system PM hooks to the NOIRQ phase Samuel Holland
2023-11-13 7:50 ` Peter Korsgaard
2023-11-13 17:45 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox