From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18723C4167D for ; Tue, 14 Nov 2023 13:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233199AbjKNN24 (ORCPT ); Tue, 14 Nov 2023 08:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbjKNN2w (ORCPT ); Tue, 14 Nov 2023 08:28:52 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F7E91B5; Tue, 14 Nov 2023 05:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699968529; x=1731504529; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=imjIYLKBTVSlegQE2rvCKcNc9nXKA3MpxHpU4ufHEXw=; b=fqRC0isIKWZo5Y/maw6XIBM2IUGdec9N8wTSJcV3uQtBf070mpuDAElT Gg5Noswke+1MIw0Bh2OLqFzfDtJSluwToVmzwUIXY/Mrt+p6nBoJqw9rQ mPUnWnISr/cne3XXvMJS0b0xouW73M7r7S4r2PyCY+lhb3JF5pgsh/i68 MYrFskXA0QpzdhqqW6H9ueEVfOPOrWR7CHD+XWDMIvSeB6bDggLwKA49d 55niFY7PKd4o1k/benHpPricHYECHhfnhTIFapytekIe8tKbph29fnTOf /bwsDKC9oO5+onOB83IUojpIcK6YQQQ6oCYpAkLMFc8ZfMZvsDKWAgf72 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="3758997" X-IronPort-AV: E=Sophos;i="6.03,302,1694761200"; d="scan'208";a="3758997" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 05:28:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="908360728" X-IronPort-AV: E=Sophos;i="6.03,302,1694761200"; d="scan'208";a="908360728" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 05:28:45 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1r2tT7-0000000Dp4R-3ayb; Tue, 14 Nov 2023 15:28:41 +0200 Date: Tue, 14 Nov 2023 15:28:41 +0200 From: Andy Shevchenko To: Herve Codina Cc: Saravana Kannan , Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Sakari Ailus , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Thomas Petazzoni , stable@vger.kernel.org Subject: Re: [PATCH 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0 Message-ID: References: <20231114110456.273844-1-herve.codina@bootlin.com> <20231114141934.1b0d44e2@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2023 at 03:27:43PM +0200, Andy Shevchenko wrote: > On Tue, Nov 14, 2023 at 02:19:34PM +0100, Herve Codina wrote: > > On Tue, 14 Nov 2023 15:12:47 +0200 > > Andy Shevchenko wrote: > > > On Tue, Nov 14, 2023 at 12:04:56PM +0100, Herve Codina wrote: > > > > A refcount issue can appeared in __fwnode_link_del() due to the > > > > pr_debug() call: ---8<--- > > > > WARNING: CPU: 0 PID: 901 at lib/refcount.c:25 refcount_warn_saturate+0xe5/0x110 > > > > Call Trace: > > > > ? refcount_warn_saturate+0xe5/0x110 > > ... These are actually not needed as duplicating WARNING above. > > > > of_node_get+0x1e/0x30 > > > > of_fwnode_get+0x28/0x40 > > > > fwnode_full_name_string+0x34/0x90 > > > > fwnode_string+0xdb/0x140 > ... > > > > > vsnprintf+0x17b/0x630 > ... > > > > __fwnode_link_del+0x25/0xa0 > > > > fwnode_links_purge+0x39/0xb0 > > > > of_node_release+0xd9/0x180 > ... ---8<--- > > > Please, do not put so many unrelated lines of backtrace in the commit message. > > > Leave only the important ones (the Submitting Patches document suggests some > > > like ~3-5 lines only). > > > > Ok, I will remove some of them. > > Thanks (my suggestion is above). -- With Best Regards, Andy Shevchenko