* [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks
@ 2023-11-03 23:03 Elliot Berman
2023-11-14 20:59 ` Rob Herring
2023-11-15 7:15 ` Johan Hovold
0 siblings, 2 replies; 4+ messages in thread
From: Elliot Berman @ 2023-11-03 23:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Elliot Berman, Krzysztof Kozlowski, linux-arm-msm, linux-phy,
devicetree, linux-kernel
I noticed while running make dtbs_check that
qcom,sm8450-qmp-gen3x1-pcie-phy and qcom,sm8450-qmp-gen4x2-pcie-phy have
4 clocks, not 5. There was also a typo for the 8450 bindings:
s/gen3x2/gen4x2/.
Update the bindings to reflect the correct number of required clocks.
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 505fb2541678 ("dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml")
Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
---
.../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
index 2c3d6553a7ba..1768f2016a9f 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
@@ -128,6 +128,20 @@ allOf:
reg:
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm8450-qmp-gen3x1-pcie-phy
+ - qcom,sm8450-qmp-gen4x2-pcie-phy
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ clock-names:
+ minItems: 4
+
- if:
properties:
compatible:
@@ -143,8 +157,6 @@ allOf:
- qcom,sm8250-qmp-gen3x2-pcie-phy
- qcom,sm8250-qmp-modem-pcie-phy
- qcom,sm8350-qmp-gen3x1-pcie-phy
- - qcom,sm8450-qmp-gen3x1-pcie-phy
- - qcom,sm8450-qmp-gen3x2-pcie-phy
- qcom,sm8550-qmp-gen3x2-pcie-phy
- qcom,sm8550-qmp-gen4x2-pcie-phy
then:
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks
2023-11-03 23:03 [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks Elliot Berman
@ 2023-11-14 20:59 ` Rob Herring
2023-11-15 7:15 ` Johan Hovold
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-11-14 20:59 UTC (permalink / raw)
To: Elliot Berman
Cc: Rob Herring, Krzysztof Kozlowski, Vinod Koul,
Kishon Vijay Abraham I, linux-phy, Andy Gross, Dmitry Baryshkov,
devicetree, Krzysztof Kozlowski, Konrad Dybcio, Conor Dooley,
Bjorn Andersson, linux-arm-msm, linux-kernel
On Fri, 03 Nov 2023 16:03:38 -0700, Elliot Berman wrote:
> I noticed while running make dtbs_check that
> qcom,sm8450-qmp-gen3x1-pcie-phy and qcom,sm8450-qmp-gen4x2-pcie-phy have
> 4 clocks, not 5. There was also a typo for the 8450 bindings:
> s/gen3x2/gen4x2/.
>
> Update the bindings to reflect the correct number of required clocks.
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 505fb2541678 ("dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml")
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks
2023-11-03 23:03 [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks Elliot Berman
2023-11-14 20:59 ` Rob Herring
@ 2023-11-15 7:15 ` Johan Hovold
2023-11-15 15:03 ` Elliot Berman
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2023-11-15 7:15 UTC (permalink / raw)
To: Elliot Berman
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Krzysztof Kozlowski,
linux-arm-msm, linux-phy, devicetree, linux-kernel
On Fri, Nov 03, 2023 at 04:03:38PM -0700, Elliot Berman wrote:
> I noticed while running make dtbs_check that
> qcom,sm8450-qmp-gen3x1-pcie-phy and qcom,sm8450-qmp-gen4x2-pcie-phy have
> 4 clocks, not 5. There was also a typo for the 8450 bindings:
> s/gen3x2/gen4x2/.
>
> Update the bindings to reflect the correct number of required clocks.
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 505fb2541678 ("dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml")
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> index 2c3d6553a7ba..1768f2016a9f 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
> @@ -128,6 +128,20 @@ allOf:
> reg:
> maxItems: 1
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sm8450-qmp-gen3x1-pcie-phy
> + - qcom,sm8450-qmp-gen4x2-pcie-phy
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + clock-names:
> + minItems: 4
> +
I'm not sure which tree you think you're looking at but this is clearly
not correct.
The phy nodes in arch/arm64/boot/dts/qcom/sm8450.dtsi have five clocks
defined.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks
2023-11-15 7:15 ` Johan Hovold
@ 2023-11-15 15:03 ` Elliot Berman
0 siblings, 0 replies; 4+ messages in thread
From: Elliot Berman @ 2023-11-15 15:03 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Krzysztof Kozlowski,
linux-arm-msm, linux-phy, devicetree, linux-kernel
On 11/15/2023 2:15 AM, Johan Hovold wrote:
> On Fri, Nov 03, 2023 at 04:03:38PM -0700, Elliot Berman wrote:
>> I noticed while running make dtbs_check that
>> qcom,sm8450-qmp-gen3x1-pcie-phy and qcom,sm8450-qmp-gen4x2-pcie-phy have
>> 4 clocks, not 5. There was also a typo for the 8450 bindings:
>> s/gen3x2/gen4x2/.
>>
>> Update the bindings to reflect the correct number of required clocks.
>>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Fixes: 505fb2541678 ("dt-bindings: phy: migrate QMP PCIe PHY bindings to qcom,sc8280xp-qmp-pcie-phy.yaml")
>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
>> ---
>> .../bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 16 ++++++++++++++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> index 2c3d6553a7ba..1768f2016a9f 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml
>> @@ -128,6 +128,20 @@ allOf:
>> reg:
>> maxItems: 1
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sm8450-qmp-gen3x1-pcie-phy
>> + - qcom,sm8450-qmp-gen4x2-pcie-phy
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 4
>> + clock-names:
>> + minItems: 4
>> +
>
> I'm not sure which tree you think you're looking at but this is clearly
> not correct.
>
> The phy nodes in arch/arm64/boot/dts/qcom/sm8450.dtsi have five clocks
> defined.
>
You're right, next now has 5 clocks for 8450. -next vs. tip of tree strikes me again :)
I'll send out a fix for just the typo tomorrow/Friday when I do another sweep of
dtbs_check (on next/master instead of torvalds/master).
> Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-15 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-03 23:03 [PATCH] dt-bindings: phy: Document sm8450 pcie phys as having 4 clocks Elliot Berman
2023-11-14 20:59 ` Rob Herring
2023-11-15 7:15 ` Johan Hovold
2023-11-15 15:03 ` Elliot Berman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox