From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EA7C48BD7 for ; Wed, 15 Nov 2023 13:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344046AbjKONzF (ORCPT ); Wed, 15 Nov 2023 08:55:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234966AbjKONzA (ORCPT ); Wed, 15 Nov 2023 08:55:00 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F387188; Wed, 15 Nov 2023 05:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700056497; x=1731592497; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ohgO+ECJ696My33rCFnHkhZ3Hw1Qg8m9gAw1iQ1RADw=; b=nwMkXKVqDP+thMcoyheBssDuwnuvHCBjWu3AmI1uLIw4o12umKxAoNOm B/Stg2OhsesIxtCBE+Oqip7V7VYH1Uu/mj7l0CxcCp4rcmluBN6TprgPI 9n9hu1kt7x+tWzYHyLIaaqFZ4+KK9nytylet1DgXwxrBVvCcECCYHztGa bktOixLo6E1E/gxrihFW2n0T7/gxZR4SGGotNX85mrgzXjk3COWDjOgqO TgU/BeDE/5oDtT+jjqZqOO56CfAX1HfIdohx3b83SMqp6yvvMNvHJixO6 Qe5B8oKy8oDpbZyKVPwZt8ZOVtLrH0ygXh3seo1E/U/MvgyxZh4o6d7OD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="375917967" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="375917967" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 05:54:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="758501857" X-IronPort-AV: E=Sophos;i="6.03,305,1694761200"; d="scan'208";a="758501857" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 05:54:53 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r3GLx-0000000EKTS-447E; Wed, 15 Nov 2023 15:54:49 +0200 Date: Wed, 15 Nov 2023 15:54:49 +0200 From: Andy Shevchenko To: Jarkko Nikula Cc: Mario Limonciello , Herbert Xu , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , Hans de Goede Subject: Re: [PATCH v3 04/25] i2c: designware: Let PCI core to take care about interrupt vectors Message-ID: References: <20231110182304.3894319-1-andriy.shevchenko@linux.intel.com> <20231110182304.3894319-5-andriy.shevchenko@linux.intel.com> <8869c8e7-9b20-4a4c-83dc-65ce48bbe9c8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8869c8e7-9b20-4a4c-83dc-65ce48bbe9c8@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2023 at 02:08:10PM +0200, Jarkko Nikula wrote: > On 11/10/23 20:11, Andy Shevchenko wrote: ... > > @@ -360,9 +354,6 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev) > > pm_runtime_forbid(&pdev->dev); > > pm_runtime_get_noresume(&pdev->dev); > > - > > - devm_free_irq(&pdev->dev, dev->irq, dev); > > - pci_free_irq_vectors(pdev); > > Instead of commit 21aa3983d619 I guess this patch is more around my commit > 9be8bc4dd617 ("i2c: designware-pci: Fix BUG_ON during device removal")? No, this one exactly what it says. Your patch is the side effect of the above mentioned change. > But > still I don't think it qualifies Fixes tag? Up to you, I can remove the fixes tag altogether, but it has the correct commit ID there. > I was curious to see would this patch bring back above BUG_ON and > fortunately not (rmmod/modprobe i2c_designware_pci on MSI enabled > instance):-) How? PCI clean up will happen on the level of pcim_enable_device(), i.e. quite after the IRQ will be freed. -- With Best Regards, Andy Shevchenko