Re: [PATCH 4/6] PCI: qcom: Clean up ASPM comment

Manivannan Sadhasivam
2023-11-17T10:32:42Z

On Tue, Nov 14, 2023 at 02:55:51PM +0100, Johan Hovold wrote:
> Break up the newly added ASPM comment so that it fits within the soft 80
> character limit and becomes more readable.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

I think we discussed (80column soft limit for comments) in the past, but I don't
think breaking here makes the comment more readable.

- Mani

> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 21523115f6a4..a6f08acff3d4 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -969,7 +969,10 @@ static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie)
>
> static int qcom_pcie_enable_aspm(struct pci_dev *pdev, void *userdata)
> {
> - /* Downstream devices need to be in D0 state before enabling PCI PM substates */
> + /*
> + * Downstream devices need to be in D0 state before enabling PCI PM
> + * substates.
> + */
> pci_set_power_state(pdev, PCI_D0);
> pci_enable_link_state_locked(pdev, PCIE_LINK_STATE_ALL);
>
> --
> 2.41.0
>

--
மணிவண்ணன் சதாசிவம்