From: Catalin Marinas <catalin.marinas@arm.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] kmemleak: drop (age <increasing>) from leak record
Date: Sat, 18 Nov 2023 17:35:01 +0000 [thread overview]
Message-ID: <ZVj1xcqVRDr7gZYP@arm.com> (raw)
In-Reply-To: <20231116224318.124209-2-jim.cromie@gmail.com>
On Thu, Nov 16, 2023 at 03:43:17PM -0700, Jim Cromie wrote:
> Displaying age is pretty, but counter-productive; it changes with
> current-time, so it surrenders idempotency of the output, which breaks
> simple hash-based cataloging of the records by the user.
>
> The trouble: sequential reads, wo new leaks, get new results:
>
> :#> sum /sys/kernel/debug/kmemleak
> 53439 74 /sys/kernel/debug/kmemleak
> :#> sum /sys/kernel/debug/kmemleak
> 59066 74 /sys/kernel/debug/kmemleak
>
> and age is why (nothing else changes):
>
> :#> grep -v age /sys/kernel/debug/kmemleak | sum
> 58894 67
> :#> grep -v age /sys/kernel/debug/kmemleak | sum
> 58894 67
>
> Since jiffies is already printed in the "comm" line, age adds nothing.
>
> Notably, syzkaller reads kmemleak only for "unreferenced object", and
> won't care about this reform of age-ism. A few moribund github repos
> mention it, but don't compile.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2023-11-18 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 22:43 [PATCH 0/2] tweak kmemleak report format Jim Cromie
2023-11-16 22:43 ` [PATCH 1/2] kmemleak: drop (age <increasing>) from leak record Jim Cromie
2023-11-18 17:35 ` Catalin Marinas [this message]
2023-11-16 22:43 ` [PATCH 2/2] kmemleak: add checksum to backtrace report Jim Cromie
2023-11-18 17:36 ` Catalin Marinas
2023-11-26 6:44 ` jim.cromie
2023-11-16 23:22 ` [PATCH 0/2] tweak kmemleak report format jim.cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVj1xcqVRDr7gZYP@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox