From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE875C2BB3F for ; Sat, 18 Nov 2023 17:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbjKRRgS (ORCPT ); Sat, 18 Nov 2023 12:36:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbjKRRgQ (ORCPT ); Sat, 18 Nov 2023 12:36:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B850612B for ; Sat, 18 Nov 2023 09:36:13 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8162BC433C8; Sat, 18 Nov 2023 17:36:12 +0000 (UTC) Date: Sat, 18 Nov 2023 17:36:09 +0000 From: Catalin Marinas To: Jim Cromie Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/2] kmemleak: add checksum to backtrace report Message-ID: References: <20231116224318.124209-1-jim.cromie@gmail.com> <20231116224318.124209-3-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116224318.124209-3-jim.cromie@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2023 at 03:43:18PM -0700, Jim Cromie wrote: > Change /sys/kernel/debug/kmemleak report format slightly, adding > "(extra info)" to the backtrace header: > > from: " backtrace:" > to: " backtrace (crc ):" > > The allows a user to see recurring backtraces without > detailed/careful reading of multiline stacks. So after cycling > kmemleak-test a few times, I know some leaks are repeating. > > bash-5.2# grep backtrace /sys/kernel/debug/kmemleak | wc > 62 186 1792 > bash-5.2# grep backtrace /sys/kernel/debug/kmemleak | sort -u | wc > 37 111 1067 > > syzkaller parses kmemleak for "unreferenced object" only, so is > unaffected by this change. Other github repos are moribund. > > Signed-off-by: Jim Cromie Reviewed-by: Catalin Marinas