public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
@ 2023-10-16 13:26 Andy Shevchenko
  2023-11-20 17:19 ` Andy Shevchenko
  2024-02-02 15:35 ` Andy Shevchenko
  0 siblings, 2 replies; 8+ messages in thread
From: Andy Shevchenko @ 2023-10-16 13:26 UTC (permalink / raw)
  To: Andy Shevchenko, Matthew Wilcox (Oracle), linux-kernel; +Cc: Andrew Morton

Use a predefined limit instead of hardcoding it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v1: resent with Andrew in Cc list
Initial contribution was here more than a month ago:
https://lore.kernel.org/r/20230911224500.16677-1-andriy.shevchenko@linux.intel.com
 lib/logic_pio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/logic_pio.c b/lib/logic_pio.c
index 2ea564a40064..1cab23e4f856 100644
--- a/lib/logic_pio.c
+++ b/lib/logic_pio.c
@@ -175,7 +175,7 @@ resource_size_t logic_pio_to_hwaddr(unsigned long pio)
 	if (range)
 		return range->hw_start + pio - range->io_start;
 
-	return (resource_size_t)~0;
+	return RESOURCE_SIZE_MAX;
 }
 
 /**
-- 
2.40.0.1.gaa8946217a0b


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
  2023-10-16 13:26 [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition Andy Shevchenko
@ 2023-11-20 17:19 ` Andy Shevchenko
  2023-12-22 15:03   ` Andy Shevchenko
  2024-02-02 15:35 ` Andy Shevchenko
  1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-11-20 17:19 UTC (permalink / raw)
  To: Matthew Wilcox (Oracle), linux-kernel; +Cc: Andrew Morton

On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> Use a predefined limit instead of hardcoding it.

Any comments on this?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
  2023-11-20 17:19 ` Andy Shevchenko
@ 2023-12-22 15:03   ` Andy Shevchenko
  2023-12-22 16:11     ` Matthew Wilcox
  0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-12-22 15:03 UTC (permalink / raw)
  To: Matthew Wilcox (Oracle), linux-kernel; +Cc: Andrew Morton

On Mon, Nov 20, 2023 at 07:19:08PM +0200, Andy Shevchenko wrote:
> On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > Use a predefined limit instead of hardcoding it.
> 
> Any comments on this?

It's month passed, can this be applied if no further comments?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
  2023-12-22 15:03   ` Andy Shevchenko
@ 2023-12-22 16:11     ` Matthew Wilcox
  0 siblings, 0 replies; 8+ messages in thread
From: Matthew Wilcox @ 2023-12-22 16:11 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: linux-kernel, Andrew Morton, John Garry, Gabriele Paoloni,
	Zhichang Yuan

On Fri, Dec 22, 2023 at 05:03:00PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 20, 2023 at 07:19:08PM +0200, Andy Shevchenko wrote:
> > On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > > Use a predefined limit instead of hardcoding it.
> > 
> > Any comments on this?
> 
> It's month passed, can this be applied if no further comments?

Maybe you should cc someone who knows about and cares about the
code instead of someone who did a driveby patch recently?
get_maintainer.pl is not a replacement for using your brain.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
  2023-10-16 13:26 [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition Andy Shevchenko
  2023-11-20 17:19 ` Andy Shevchenko
@ 2024-02-02 15:35 ` Andy Shevchenko
  2024-02-02 22:37   ` Matthew Wilcox
  1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2024-02-02 15:35 UTC (permalink / raw)
  To: Matthew Wilcox (Oracle), linux-kernel; +Cc: Andrew Morton

On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> Use a predefined limit instead of hardcoding it.

Can we apply this one?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
@ 2024-02-02 15:45 Andy Shevchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-02-02 15:45 UTC (permalink / raw)
  To: Andy Shevchenko, Matthew Wilcox (Oracle), linux-kernel
  Cc: Andrew Morton, John Garry, Wei Xu, Gabriele Paoloni,
	Zhichang Yuan

Use a predefined limit instead of hardcoding it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v1: resent with the main contributrs in the Cc list
Initial contribution was here more than a few months ago:
https://lore.kernel.org/r/20230911224500.16677-1-andriy.shevchenko@linux.intel.com
followed by
20231016132611.1201402-1-andriy.shevchenko@linux.intel.com

 lib/logic_pio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/logic_pio.c b/lib/logic_pio.c
index 2ea564a40064..1cab23e4f856 100644
--- a/lib/logic_pio.c
+++ b/lib/logic_pio.c
@@ -175,7 +175,7 @@ resource_size_t logic_pio_to_hwaddr(unsigned long pio)
 	if (range)
 		return range->hw_start + pio - range->io_start;
 
-	return (resource_size_t)~0;
+	return RESOURCE_SIZE_MAX;
 }
 
 /**
-- 
2.43.0.rc1.1.gbec44491f096


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
  2024-02-02 15:35 ` Andy Shevchenko
@ 2024-02-02 22:37   ` Matthew Wilcox
  0 siblings, 0 replies; 8+ messages in thread
From: Matthew Wilcox @ 2024-02-02 22:37 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-kernel, Andrew Morton

On Fri, Feb 02, 2024 at 05:35:42PM +0200, Andy Shevchenko wrote:
> On Mon, Oct 16, 2023 at 04:26:11PM +0300, Andy Shevchenko wrote:
> > Use a predefined limit instead of hardcoding it.
> 
> Can we apply this one?

Why are you asking me?  I don't even know what this driver is for.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition
@ 2025-06-26 17:23 Andy Shevchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2025-06-26 17:23 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Andy Shevchenko

Use a predefined limit instead of hardcoding it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/logic_pio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/logic_pio.c b/lib/logic_pio.c
index e29496a38d06..6d6a7498dbe5 100644
--- a/lib/logic_pio.c
+++ b/lib/logic_pio.c
@@ -175,7 +175,7 @@ resource_size_t logic_pio_to_hwaddr(unsigned long pio)
 	if (range)
 		return range->hw_start + pio - range->io_start;
 
-	return (resource_size_t)~0;
+	return RESOURCE_SIZE_MAX;
 }
 
 /**
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-06-26 17:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 13:26 [resend, PATCH v1 1/1] logic_pio: Use RESOURCE_SIZE_MAX definition Andy Shevchenko
2023-11-20 17:19 ` Andy Shevchenko
2023-12-22 15:03   ` Andy Shevchenko
2023-12-22 16:11     ` Matthew Wilcox
2024-02-02 15:35 ` Andy Shevchenko
2024-02-02 22:37   ` Matthew Wilcox
  -- strict thread matches above, loose matches on Subject: below --
2024-02-02 15:45 Andy Shevchenko
2025-06-26 17:23 Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox