public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Yong He <zhuangel570@gmail.com>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: fix invalid cpu in kick_pool
Date: Mon, 20 Nov 2023 09:07:34 -1000	[thread overview]
Message-ID: <ZVuudtAtDqHqYJr8@slm.duckdns.org> (raw)
In-Reply-To: <20231120121623.119780-1-alexyonghe@tencent.com>

Hello,

On Mon, Nov 20, 2023 at 08:16:23PM +0800, Yong He wrote:
> With incorrect unbound workqueue configurations, this may introduce kernel
> panic, because cpumask_any_distribute() will not always return a valid cpu,
> such as one set the 'isolcpus' and 'workqueue.unbound_cpus' into the same
> cpuset, and this will make the @pool->attrs->__pod_cpumask an empty set,
> then trigger panic like this:

This shouldn't have happened. Can you share the configuration and the full
dmesg? Let's fix the problem at the source.

Thanks.

-- 
tejun

  reply	other threads:[~2023-11-20 19:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 12:16 [PATCH] workqueue: fix invalid cpu in kick_pool Yong He
2023-11-20 19:07 ` Tejun Heo [this message]
2023-11-21  4:01   ` zhuangel570
2023-11-21 21:39     ` [PATCH] workqueue: Make sure that wq_unbound_cpumask is never empty Tejun Heo
2023-11-22  3:36       ` zhuangel570
     [not found]       ` <8f469287-e29a-4473-a181-9013292ef62c@redhat.com>
2023-11-22 16:03         ` Tejun Heo
2023-11-22 16:23           ` Tejun Heo
2023-11-22 19:10             ` Waiman Long
2023-11-22 16:03       ` Tejun Heo
2023-11-20 21:01 ` [PATCH] workqueue: fix invalid cpu in kick_pool kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVuudtAtDqHqYJr8@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhuangel570@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox