From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17FBC5ACB3 for ; Tue, 21 Nov 2023 09:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbjKUJRL (ORCPT ); Tue, 21 Nov 2023 04:17:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjKUJRJ (ORCPT ); Tue, 21 Nov 2023 04:17:09 -0500 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4FB7E8; Tue, 21 Nov 2023 01:17:04 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 3A3791F83F; Tue, 21 Nov 2023 10:17:01 +0100 (CET) Date: Tue, 21 Nov 2023 10:16:57 +0100 From: Francesco Dolcini To: Thorsten Leemhuis , linux@bigler.io Cc: Francesco Dolcini , Stefan Moring , Linux regressions mailing list , Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm Message-ID: References: <2fcdd99eee9ee4f5d34fa1abab2f51bb@mail.infomaniak.com> <86566391db9c5044f1a082bc8ec697a2@mail.infomaniak.com> <6322fd4c1967a518310140c35ab34f65@mail.infomaniak.com> <90abbd7a-e3e3-42c9-9be9-28e475f0fc9a@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90abbd7a-e3e3-42c9-9be9-28e475f0fc9a@leemhuis.info> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2023 at 10:06:51AM +0100, Thorsten Leemhuis wrote: > On 20.11.23 18:48, Francesco Dolcini wrote: > > On Mon, Nov 20, 2023 at 04:30:15PM +0100, Stefan Moring wrote: > >> Can you verify the values used for the transfer,  spi_imx->count and spi_imx-> > >> bits_per_word inside the mx51_ecpsi_prepare_transfer() method? Those are the > >> only two things that changed in the commits. Maybe compare them to the working > >> version? > > > > I would suggest to bisect the issue to the actual commit that > > introduced the regression, I do not think this was done yet. > > I think it was. To quote Whoops, you are right. > spi: Increase imx51 ecspi burst length based on transfer length > 15a6af94a2779d5dfb42ee4bfac858ea8e964a3f > > spi: imx: Take in account bits per word instead of assuming 8-bits > 5f66db08cbd3ca471c66bacb0282902c79db9274 Do we know which one of those two commits introduces this regression? Francesco