From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7356EC54FB9 for ; Tue, 21 Nov 2023 06:41:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbjKUGlY (ORCPT ); Tue, 21 Nov 2023 01:41:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjKUGlV (ORCPT ); Tue, 21 Nov 2023 01:41:21 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2998B90 for ; Mon, 20 Nov 2023 22:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700548877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nAT6s1p7Zejr5qyruucrwjjja96dwkjMkL3IvSvg+bw=; b=ee+R59VWHOdBnw7DZwvMl0R2efk1weqHqx4YgFxs47/NWi6c0uNWiu8/ofeiTUQ3lB6pHJ LupOhQ/AtjxLQGTnE0ywulQrSAbTd5xDHbZxOa0OXqjGISWeG1ATB3s1+UgqPFj/eg8Dds q53kSQm1nq2xocpq+4ekcGdcH72bq0I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-Bukgdl4uPLCcmaLRQ3qb2Q-1; Tue, 21 Nov 2023 01:41:13 -0500 X-MC-Unique: Bukgdl4uPLCcmaLRQ3qb2Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00B5584AF89; Tue, 21 Nov 2023 06:41:13 +0000 (UTC) Received: from localhost (unknown [10.72.112.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CDC81121306; Tue, 21 Nov 2023 06:41:11 +0000 (UTC) Date: Tue, 21 Nov 2023 14:41:08 +0800 From: Baoquan He To: "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , ltao@redhat.com, Borislav Petkov , Dave Hansen , x86@kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 00/14] x86/tdx: Add kexec support Message-ID: References: <20231115120044.8034-1-kirill.shutemov@linux.intel.com> <20231116125612.daxettqcapled7ac@box.shutemov.name> <20231117124748.umfuc3no2qvh4shj@box.shutemov.name> <20231117154632.zvi6g6lblmtvikzt@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231117154632.zvi6g6lblmtvikzt@box> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/23 at 06:46pm, Kirill A. Shutemov wrote: > On Fri, Nov 17, 2023 at 11:03:00PM +0800, Baoquan He wrote: > > On 11/17/23 at 03:47pm, Kirill A. Shutemov wrote: > > > On Thu, Nov 16, 2023 at 10:45:23PM +0800, Baoquan He wrote: > > > > On 11/16/23 at 10:17pm, Baoquan He wrote: > > > > > On 11/16/23 at 03:56pm, Kirill A. Shutemov wrote: > > > > > > On Thu, Nov 16, 2023 at 08:10:47PM +0800, Baoquan He wrote: > > > > > > > On 11/15/23 at 03:00pm, Kirill A. Shutemov wrote: > > > > > > > > The patchset adds bits and pieces to get kexec (and crashkernel) work on > > > > > > > > TDX guest. > > > > > > > > > > > > > > I finally got a machine of intel-eaglestream-spr as host and built a > > > > > > > tdx guest to give it a shot, the kexec reboot is working very well, > > > > > > > while kdump kernel always failed to boot up. I only built kernel and > > > > > > > installed it on tdx guest. > > > > > > > ------------------------------------------ > > > > > > > [ 1.422500] Run /init as init process > > > > > > > [ 1.423073] Failed to execute /init (error -2) > > > > > > > [ 1.423759] Run /sbin/init as init process > > > > > > > [ 1.424370] Run /etc/init as init process > > > > > > > [ 1.424969] Run /bin/init as init process > > > > > > > [ 1.425588] Run /bin/sh as init process > > > > > > > [ 1.426150] Kernel panic - not syncing: No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance. > > > > > > > [ 1.428122] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.7.0-rc1-00014-gbdba31ba3cec #3 > > > > > > > [ 1.429232] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS unknown 2/2/2022 > > > > > > > [ 1.430328] Call Trace: > > > > > > > [ 1.430717] > > > > > > > [ 1.431041] dump_stack_lvl+0x33/0x50 > > > > > > > [ 1.431581] panic+0x324/0x340 > > > > > > > [ 1.432037] ? __pfx_kernel_init+0x10/0x10 > > > > > > > [ 1.432629] kernel_init+0x174/0x1c0 > > > > > > > [ 1.433149] ret_from_fork+0x2d/0x50 > > > > > > > [ 1.433690] ? __pfx_kernel_init+0x10/0x10 > > > > > > > [ 1.434277] ret_from_fork_asm+0x1b/0x30 > > > > > > > [ 1.434850] > > > > > > > [ 1.435345] Kernel Offset: disabled > > > > > > > [ 1.439216] Rebooting in 10 seconds.. > > > > > > > qemu-kvm: cpus are not resettable, terminating > > > > > > > > > > > > Could you shared your kernel config and details about your setup (qemu > > > > > > command, kernel command line, ...)? > > > > > > > > > > We followed tdx-tools README to setup the environment and built host and > > > > > guest kernel, qemu command is as below. I copied the > > > > > tdx-tools/build/rhel-9/intel-mvp-tdx-kernel/tdx-base.config to the > > > > > latest upstream linxu kernel then execute 'make olddefconfig'. Because > > > > > your patchset can't be applied to the stable kernel with the 731 > > > > > patches. > > > > > > > > > > cd /home/root/tdx-tools > > > > > ./start-qemu.sh -i /home/root/guest_tdx.qcow2 -b grub > > > > > > > > This is the qemu command when execute above line of command, just for > > > > your reference if you happen to not take this way. > > > > > > Still failed to reproduce :/ > > > > > > Blind shot: could you check if the patch below makes any difference. > > > > Still failed. And I found the normal reboot does't work either. I will > > do more testing tomorrow, e.g use the tdx-tools's own rhel9 kernel > > config and rebuild, and update host kernel too. I did more tests, resuls are summarized as below: 1) kexec reboot works, but always fallback to 1 cpu even though multiple cpus are specified; 2) kdump kernel need more crashkernel memory to boot up, crashkernel=512M works well in our case. But it failed in vmcore saving process, either makedumpfile or cp can't access the 1st kernel's old memory; 3) Normal reboot always failed; My colleague Tao helped to double check this, he got the same testing result. Plesae 1) what can we do to enable the multiple cpu support for kexec reboot? 2) anything missing to allow makedumpfile/cp access 1st kernel's memory? 3) not sure if this is particular case on the system we tested on. Thanks Baoquan