From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer
Date: Tue, 21 Nov 2023 17:39:13 +0100 [thread overview]
Message-ID: <ZVzdMWawUScUTUM3@tuxmaker.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20231121103626.17772-2-jirislaby@kernel.org>
On Tue, Nov 21, 2023 at 11:36:21AM +0100, Jiri Slaby (SUSE) wrote:
> clang-struct [1] found raw3215_info::ubuffer unused.
>
> It's actually not used since 2004 when we switched to kernel buffers.
>
> [1] https://github.com/jirislaby/clang-struct
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
> drivers/s390/char/con3215.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 99361618c31f..34bc343dcfcc 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -89,7 +89,6 @@ struct raw3215_info {
> wait_queue_head_t empty_wait; /* wait queue for flushing */
> struct timer_list timer; /* timer for delayed output */
> int line_pos; /* position on the line (for tabs) */
> - char ubuffer[80]; /* copy_from_user buffer */
> };
>
> /* array of 3215 devices structures */
Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>
next prev parent reply other threads:[~2023-11-21 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:36 [PATCH 0/6] tty: remove unused structure members Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer Jiri Slaby (SUSE)
2023-11-21 16:39 ` Alexander Gordeev [this message]
2023-11-21 10:36 ` [PATCH 2/6] tty: ipwireless: remove unused ipw_dev::attribute_memory Jiri Slaby (SUSE)
2023-11-21 12:18 ` Jiri Kosina
2023-11-21 18:30 ` David Sterba
2023-11-21 10:36 ` [PATCH 3/6] tty: jsm: remove unused members from struct board_ops Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 4/6] tty: jsm: remove unused struct jsm_board members Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 5/6] tty: rp2: remove unused rp2_uart_port::ignore_rx Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 6/6] tty: serial_cs: remove unused struct serial_cfg_mem Jiri Slaby (SUSE)
2023-11-21 15:35 ` [PATCH 0/6] tty: remove unused structure members Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVzdMWawUScUTUM3@tuxmaker.boeblingen.de.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox