From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6103CC61D90 for ; Tue, 21 Nov 2023 17:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233920AbjKURPp (ORCPT ); Tue, 21 Nov 2023 12:15:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233818AbjKURPn (ORCPT ); Tue, 21 Nov 2023 12:15:43 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C391510E; Tue, 21 Nov 2023 09:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700586939; x=1732122939; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S9sccXWZMCeaoBSIUXxMBPcEyCWpWSBji+ESLneAGus=; b=d22j2hlc/T042yw7s5LhdIUA08tuxljEjmSSJjYdNoSwkIMtQN6j1STt GL33z5Bb3ZsPgq3wuFL0giw5CE+elUjtpBBfPpYv6Jtfx8isxrEIBqnVb L9RIK0yTkfEE0KSSlMIRRcO+9HDsB4G9CqqmBCMQ7FBdjdPpUOgYYkFwP sDn6HyZPa2YG3UO8BzVaBqC294QAq/dirKedBYRQ3/VtfHtRwvBJ5il0s X/30dYda26iFnLmPw7npULOC0kURoTbQc7ocwNrnSt2BN5U3l+3HsJS+o goWG6b8na6Jb5dZn2aMRH4lRcsiE0hiOEbssvefEUO2+eXMBnAVAFRTVZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="5012006" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="5012006" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 09:15:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="760154432" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="760154432" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 09:15:36 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5ULV-0000000Fs7k-3WXX; Tue, 21 Nov 2023 19:15:33 +0200 Date: Tue, 21 Nov 2023 19:15:33 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij Subject: Re: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Message-ID: References: <20231120193353.1670732-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2023 at 08:14:09AM +0100, Krzysztof Kozlowski wrote: > On 20/11/2023 20:26, Andy Shevchenko wrote: > > The group is not used anywhere, remove it. And if needed, it should be > > struct pingroup anyway. > > > > While at it, replace kernel.h with what exactly being used. > > Missing Reported-by and Closes by for LKP... Unless you discovered it > without its report? It's just at hand discovery. > Missing sm8550. And sm8650, but there LPI_FUNCTION(gpio) and I'm wondering why LKP complains about it. It's really a maze to me. > > #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \ > > { \ > > - .group.name = "gpio" #id, \ > > - .group.pins = gpio##id##_pins, \ > > Aren't these used by core pinctrl code? Only via APIs and pin control registered them also via APIs, so I don't think this is being used directly. But if you see how, tell me! I spent already a few hours on this and haven't got any clear picture in my mind. -- With Best Regards, Andy Shevchenko