From: Christoph Hellwig <hch@infradead.org>
To: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Allison Henderson <allison.henderson@oracle.com>,
Zhang Tianci <zhangtianci.1997@bytedance.com>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
xieyongji@bytedance.com, me@jcix.top,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v3 2/3] xfs: update dir3 leaf block metadata after swap
Date: Sun, 3 Dec 2023 23:18:39 -0800 [thread overview]
Message-ID: <ZW19T8PHLDx8o7ho@infradead.org> (raw)
In-Reply-To: <20231130040516.35677-3-zhangjiachen.jaycee@bytedance.com>
On Thu, Nov 30, 2023 at 12:05:15PM +0800, Jiachen Zhang wrote:
> return error;
> /*
> * Copy the last block into the dead buffer and log it.
> + * If xfs enable crc, the node/leaf block records its blkno, we
> + * must update it.
I'd rewrod this sentence as:
* On CRC-enabled file systems, also update the stamped in blkno.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-12-04 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 4:05 [PATCH v3 0/3] Fixes for ENOSPC xfs_remove Jiachen Zhang
2023-11-30 4:05 ` [PATCH v3 1/3] xfs: ensure logflagsp is initialized in xfs_bmap_del_extent_real Jiachen Zhang
2023-11-30 19:01 ` Darrick J. Wong
2023-11-30 4:05 ` [PATCH v3 2/3] xfs: update dir3 leaf block metadata after swap Jiachen Zhang
2023-12-01 0:48 ` Darrick J. Wong
2023-12-04 7:18 ` Christoph Hellwig [this message]
2023-11-30 4:05 ` [PATCH v3 3/3] xfs: extract xfs_da_buf_copy() helper function Jiachen Zhang
2023-12-04 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW19T8PHLDx8o7ho@infradead.org \
--to=hch@infradead.org \
--cc=allison.henderson@oracle.com \
--cc=bfoster@redhat.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=me@jcix.top \
--cc=xieyongji@bytedance.com \
--cc=zhangjiachen.jaycee@bytedance.com \
--cc=zhangtianci.1997@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox