Re: [PATCH V2 1/7] coresight: replicator: Move ACPI support from AMBA driver to platform driver

Sudeep Holla
2023-12-01T12:37:23Z

On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote:
> Add support for the dynamic replicator device in the platform driver, which
> can then be used on ACPI based platforms. This change would now allow
> runtime power management for repliacator devices on ACPI based systems.
>
> The driver would try to enable the APB clock if available. Also, rename the
> code to reflect the fact that it now handles both static and dynamic
> replicators.
>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>

Except the minor nit below which may apply also for few other patches
in the series

Acked-by: Sudeep Holla <sudeep.holla@arm.com> # For ACPI related changes
Tested-by: Sudeep Holla <sudeep.holla@arm.com> # Boot and driver probe only

[...]

> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index b6be73034996..64de0bee02ec 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator");
> struct replicator_drvdata {
> void __iomem *base;
> struct clk *atclk;
> + struct clk *pclk;

[minor nit] Perhaps can be documented as well ?

--
Regards,
Sudeep