Re: [PATCH V2 6/7] coresight: stm: Move ACPI support from AMBA driver to platform driver

Sudeep Holla
2023-12-04T12:00:31Z

On Mon, Dec 04, 2023 at 10:23:49AM +0000, James Clark wrote:
>
> On 01/12/2023 06:20, Anshuman Khandual wrote:
> > Add support for the stm devices in the platform driver, which can then be
> > used on ACPI based platforms. This change would now allow runtime power
> > management for ACPI based systems. The driver would try to enable the APB
> > clock if available.
> >
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> > Cc: Mike Leach <mike.leach@linaro.org>
> > Cc: James Clark <james.clark@arm.com>
> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > Cc: linux-acpi@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: coresight@lists.linaro.org
> > Cc: linux-stm32@st-md-mailman.stormreply.com
> > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> > ---
> [...]
> >
> > -module_amba_driver(stm_driver);
> > +static int stm_platform_probe(struct platform_device *pdev)
> > +{
> > + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + int ret = 0;
> > +
> > + pm_runtime_get_noresume(&pdev->dev);
> > + pm_runtime_set_active(&pdev->dev);
> > + pm_runtime_enable(&pdev->dev);
> > +
> > + ret = __stm_probe(&pdev->dev, res, NULL);
>
> Very minor nit, but this used to print this:
>
> coresight stm0: STM500 initialized
>
> And now it prints this:
>
> coresight stm0: (null) initialized
>
> (null) kind of makes it look a little bit like something has gone wrong.
> Maybe we could just put "initialised" if you don't have a string from ACPI?

Ah right, I too noticed this and forgot to mention. Just add a generic
"STM" string for ACPI if we don't have a way to identify exact IP ?

--
Regards,
Sudeep