From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: determine base DTB by suffix
Date: Mon, 4 Dec 2023 12:17:54 +0100 [thread overview]
Message-ID: <ZW21Yu73Uan+HcbL@buildd.core.avm.de> (raw)
In-Reply-To: <20231203080548.1869540-1-masahiroy@kernel.org>
On Sun, Dec 03, 2023 at 05:05:48PM +0900, Masahiro Yamada wrote:
> When using the -dtbs syntax, you need to ensure to list the base first,
> as follows:
>
> foo-dtbs := foo_base.dtb foo_overlay1.dtbo foo_overlay2.dtbo
> dtb-y := foo.dtb
>
> You cannot do this arrangement:
>
> foo-dtbs := foo_overlay1.dtbo foo_overlay2.dtbo foo_base.dtb
>
> This restriction comes from $(firstword ...), but it is unneeded to
> rely on the order in the -dtbs syntax.
>
> Instead, you can simply determine the base by suffix because the
> base (*.dtb) and overlays (*.dtbo) use different suffixes.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Thanks, looks good to me.
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
prev parent reply other threads:[~2023-12-04 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 8:05 [PATCH] kbuild: determine base DTB by suffix Masahiro Yamada
2023-12-04 11:17 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW21Yu73Uan+HcbL@buildd.core.avm.de \
--to=n.schier@avm.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox