From: Steffen Klassert <steffen.klassert@secunet.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, <antony.antony@secunet.com>,
Yonghong Song <yonghong.song@linux.dev>,
Eddy Z <eddyz87@gmail.com>, <devel@linux-ipsec.org>,
Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [PATCH ipsec-next v3 0/9] Add bpf_xdp_get_xfrm_state() kfunc
Date: Mon, 4 Dec 2023 09:25:46 +0100 [thread overview]
Message-ID: <ZW2NCm/pIthdpNgF@gauss3.secunet.de> (raw)
In-Reply-To: <dkzlpw6sj7we5xteyvbwxufqzg6axwlrvb4arq23ecaiy5ayok@jg52fqjr4ftf>
On Fri, Dec 01, 2023 at 05:16:04PM -0700, Daniel Xu wrote:
> On Fri, Dec 01, 2023 at 04:10:18PM -0800, Alexei Starovoitov wrote:
> > On Fri, Dec 1, 2023 at 12:23 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
> > >
> > > include/net/xfrm.h | 9 +
> > > net/xfrm/Makefile | 1 +
> > > net/xfrm/xfrm_policy.c | 2 +
> > > net/xfrm/xfrm_state_bpf.c | 128 ++++++++++++++
> > > tools/lib/bpf/bpf_core_read.h | 34 ++++
> > > .../selftests/bpf/prog_tests/test_tunnel.c | 162 +++++++++++++++++-
> > > .../selftests/bpf/prog_tests/verifier.c | 2 +
> > > tools/testing/selftests/bpf/progs/bpf_misc.h | 1 +
> > > .../selftests/bpf/progs/bpf_tracing_net.h | 1 +
> > > .../selftests/bpf/progs/test_tunnel_kern.c | 138 ++++++++-------
> > > .../bpf/progs/verifier_bitfield_write.c | 100 +++++++++++
> > > tools/testing/selftests/bpf/test_loader.c | 7 +
> > > tools/testing/selftests/bpf/test_tunnel.sh | 92 ----------
> > > 13 files changed, 522 insertions(+), 155 deletions(-)
> >
> > I really think this should go via bpf-next tree.
> > The bpf changes are much bigger than ipsec.
>
> Ack. Ended up picking up a lot of stuff along the way.
I'm fine with merging this via the bpf-next tree.
Please consider to merge the bpf hepler functions
to one file. We have already xfrm_interface_bpf.c
and now you introduce xfrm_state_bpf.c.
Try to merge this into a single xfrm_bpf.c file.
prev parent reply other threads:[~2023-12-04 8:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 20:23 [PATCH ipsec-next v3 0/9] Add bpf_xdp_get_xfrm_state() kfunc Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 1/9] bpf: xfrm: " Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 2/9] bpf: xfrm: Add bpf_xdp_xfrm_state_release() kfunc Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 3/9] libbpf: Add BPF_CORE_WRITE_BITFIELD() macro Daniel Xu
2023-12-01 20:51 ` [devel-ipsec] " Daniel Xu
2023-12-01 21:22 ` Eduard Zingerman
2023-12-01 23:49 ` Andrii Nakryiko
2023-12-02 0:13 ` Daniel Xu
2023-12-02 0:40 ` Andrii Nakryiko
2023-12-01 20:23 ` [PATCH ipsec-next v3 4/9] bpf: selftests: test_loader: Support __btf_path() annotation Daniel Xu
2023-12-01 23:50 ` Andrii Nakryiko
2023-12-01 20:23 ` [PATCH ipsec-next v3 5/9] libbpf: selftests: Add verifier tests for CO-RE bitfield writes Daniel Xu
2023-12-01 23:52 ` Andrii Nakryiko
2023-12-02 0:10 ` Daniel Xu
2023-12-02 0:20 ` Eduard Zingerman
2023-12-01 20:23 ` [PATCH ipsec-next v3 6/9] bpf: selftests: test_tunnel: Setup fresh topology for each subtest Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 7/9] bpf: selftests: test_tunnel: Use vmlinux.h declarations Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 8/9] bpf: selftests: Move xfrm tunnel test to test_progs Daniel Xu
2023-12-01 20:23 ` [PATCH ipsec-next v3 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state() Daniel Xu
2023-12-02 0:10 ` [PATCH ipsec-next v3 0/9] Add bpf_xdp_get_xfrm_state() kfunc Alexei Starovoitov
2023-12-02 0:16 ` Daniel Xu
2023-12-04 8:25 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW2NCm/pIthdpNgF@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=alexei.starovoitov@gmail.com \
--cc=antony.antony@secunet.com \
--cc=bpf@vger.kernel.org \
--cc=devel@linux-ipsec.org \
--cc=dxu@dxuuu.xyz \
--cc=eddyz87@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox