From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3FBC46CA0 for ; Mon, 4 Dec 2023 16:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344569AbjLDQCd (ORCPT ); Mon, 4 Dec 2023 11:02:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344461AbjLDQC2 (ORCPT ); Mon, 4 Dec 2023 11:02:28 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8784E95; Mon, 4 Dec 2023 08:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705754; x=1733241754; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=XNcK+nowG13Y865Fjff3FDTvFJmZG2WRC888K2sx/o0=; b=Fku5W+sMy8iBM7D/n3hL378vSuVSR9c8WlUhlqIiZNy3LaGTV7fvhcOV 3LolxtdbOJYDqNYEAUrtXRH85kHMnano9qphTB3bWbTkqtGIH1VqeD6De 928YwY0NI5+YLVco2aOh/ndKJRxJ57f60VH06ABXfB2xB1LBIGWIb1ptS my7LPHYO30rIvaKRNCjGfGxRC5NQ697/vMkhpWng1fZ/9OlgP6QusW1tJ 79dfGAL+MKGY78perCo99yrbJz2SIO0jsw7EPAmyH/6S/zu/1aAlgQ5ly TTYWRGuU941147mBZATQvvU7teMm13qy4JkJF9wzohVuX17ULC4xKWJIL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="631786" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="631786" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="861419788" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="861419788" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:02:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rABOl-00000001nOJ-2TZj; Mon, 04 Dec 2023 18:02:19 +0200 Date: Mon, 4 Dec 2023 18:02:19 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Marek Szyprowski , Linus Walleij , Bartosz Golaszewski , Rasmus Villemoes , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Biju Das , Claudiu Beznea , Jianlong Huang , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Paul Cercueil , Lakshmi Sowjanya D , Bjorn Andersson , Andy Gross , Konrad Dybcio , Emil Renner Berthing , Hal Feng , Krzysztof Kozlowski Subject: Re: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC() Message-ID: References: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> <20231129161459.1002323-13-andriy.shevchenko@linux.intel.com> <9e4e65de-7234-4234-8091-796277a1f1c5@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2023 at 02:39:37PM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 4, 2023 at 2:32 PM Andy Shevchenko > wrote: > > On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > > > wrote: > > > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > > > to (struct group_desc), what breaks users of the above macros. > > > > > > > > There is no cast (*). > > > > Thanks for report, I will check. > > > > > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > > > Besides that I have tested this locally with modules enabled. > > > > > > > > *) It's a compound literal, _not_ a cast. > > > > Taking above into consideration I'm wondering what compilers > > > > are in use? > > > > > > kisskb reported the following m68k failures to me: > > > linux-next/m68k-allmodconfig/m68k-gcc8 > > > linux-next/m68k-allmodconfig/m68k-gcc11 > > > linux-next/m68k-allmodconfig/m68k-gcc12 > > > > > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > > > did succeed, so I guess you are using gcc13? > > > > Yes, I compiled with these: > > > > $ gcc --version > > gcc (Debian 13.2.0-5) 13.2.0 > > Time to install and try an older version ;-) Yeah, compound literals seems the often-to-break topic (as per GCC bugzilla). Tried with GCC 8 for ARM64 and indeed it doesn't build it well. -- With Best Regards, Andy Shevchenko