From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 09/10] gpiolib: use gpiochip_dup_line_label() in for_each helpers
Date: Mon, 4 Dec 2023 15:24:33 +0200 [thread overview]
Message-ID: <ZW3TEQok8Ri-epw8@smile.fi.intel.com> (raw)
In-Reply-To: <20231204093509.19225-10-brgl@bgdev.pl>
On Mon, Dec 04, 2023 at 10:35:08AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Rework for_each_requested_gpio_in_range() to use the new helper to
> retrieve a dynamically allocated copy of the descriptor label and free
> it at the end of each iteration. We need to leverage the CLASS()'
> destructor to make sure that the label is freed even when breaking out
> of the loop.
...
> - if ((label = gpiochip_is_requested(chip, base + i)) == NULL) {} else
I see, but...
> + if ((*_data.label = \
> + gpiochip_dup_line_label(_chip, _base + *_data.i)) == NULL) {} \
...can we drop this NULL check by using !(...) notation?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-04 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 9:34 [PATCH v3 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 01/10] gpiolib: provide gpiochip_dup_line_label() Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 02/10] gpio: wm831x: use gpiochip_dup_line_label() Bartosz Golaszewski
2023-12-04 13:16 ` Andy Shevchenko
2023-12-04 13:38 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 03/10] gpio: wm8994: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 04/10] gpio: stmpe: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 05/10] pinctrl: abx500: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 06/10] pinctrl: nomadik: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 07/10] pinctrl: baytrail: " Bartosz Golaszewski
2023-12-04 13:18 ` Andy Shevchenko
2023-12-04 13:38 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 08/10] pinctrl: sppctl: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 09/10] gpiolib: use gpiochip_dup_line_label() in for_each helpers Bartosz Golaszewski
2023-12-04 13:24 ` Andy Shevchenko [this message]
2023-12-04 13:39 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 10/10] gpiolib: remove gpiochip_is_requested() Bartosz Golaszewski
2023-12-04 13:22 ` Andy Shevchenko
2023-12-05 22:49 ` [PATCH v3 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW3TEQok8Ri-epw8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox