From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7982EC4167B for ; Mon, 4 Dec 2023 18:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbjLDSKG (ORCPT ); Mon, 4 Dec 2023 13:10:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbjLDSKD (ORCPT ); Mon, 4 Dec 2023 13:10:03 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D24DAC6 for ; Mon, 4 Dec 2023 10:10:07 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40b479ec4a3so47327425e9.2 for ; Mon, 04 Dec 2023 10:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; t=1701713406; x=1702318206; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=rZbWCVcXU9/MRhjYwkods3ysAycuirphkwAN5EQWtwo=; b=CRBUcKnuK/v8/g6bh2cASELfkgKCjLnfWpRY1xdSNiJPA0K7JYKGpjEi2yDX7UUhxt XZHnTJqF5BNmRdg7u87zNQ/VbwmBKLx8z3VUu+pvF2zc7Nf6TIici9AD9kqmCj2NS/pv MD7NmExUHPAhUY5aOXnQKZWud1JYJqK+E4u+6QttGCiQpZEHZLZ8AVbIYPiGDrIyboAT Oa5yaJg49Z4EnC2d2tTiVVw9WxTcvcBkEBu32nESsdPZqs2khBCtrKJeKahWONPZmI9o fx7ENu//WCnsE2WPf4HUs7Z8ZHAechPIDuzhScTd3HBvJQWJPvdCmYfw7VGeXMhj40P7 uYKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701713406; x=1702318206; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rZbWCVcXU9/MRhjYwkods3ysAycuirphkwAN5EQWtwo=; b=BJi1za4IKLvCQlvH3W+i/XbZ3Tk6R1WG19DdPasXkgxqsEAcgNr7GcyCLWfQY13O8j yYOcOxy6imlHosCNCLIDdwic+I4XNnpw9uATWluA3XSmV5bKc/eBDYbG7h9ypbo81RG5 xgAA/hNSnRp3W3rGJzIKbQEswee77D+f+GTARr68dL5s+kr5TWR3t9VYDmjjTVnDxDMv 7fD9xXbarhexhwwM+jeLqvEBlvCFkiiRW3197/pihl5sXa8pc2/f+fz9wPybYqWsjdFb RgI1yy3gLPJI61yKzECLGXLm5upYC7MgJrQtZl0pMOGqPZkq9TFquFUQuaJsg6EfB37X 17Uw== X-Gm-Message-State: AOJu0Yxpd4KhO1COrLjclych0m1DTMu3Js459vo31ZWTACbLBBRdz+sB 0Av8Vq6HzDPbC9cYxm5QYRq09Q== X-Google-Smtp-Source: AGHT+IEu42sDOAHu0Uvi4OF+0kwVgMPrqbelTZJYNOhX/EuGwVOVKYaPYLCCf0d7tIEtl5tFP0jZYA== X-Received: by 2002:a5d:4b10:0:b0:333:85e:a11c with SMTP id v16-20020a5d4b10000000b00333085ea11cmr3194646wrq.16.1701713406280; Mon, 04 Dec 2023 10:10:06 -0800 (PST) Received: from trax (139.red-79-144-198.dynamicip.rima-tde.net. [79.144.198.139]) by smtp.gmail.com with ESMTPSA id cg16-20020a5d5cd0000000b003332656cd73sm11721629wrb.105.2023.12.04.10.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:10:05 -0800 (PST) From: "Jorge Ramirez-Ortiz, Foundries" X-Google-Original-From: "Jorge Ramirez-Ortiz, Foundries" Date: Mon, 4 Dec 2023 19:10:05 +0100 To: Christian Loehle Cc: Jorge Ramirez-Ortiz , Avri.Altman@wdc.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH] mmc: rpmb: do not force a retune before RPMB switch Message-ID: References: <20231204172243.3382495-1-jorge@foundries.io> <9747ebb3-98e6-47da-8a9b-9b7dcf7909f6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9747ebb3-98e6-47da-8a9b-9b7dcf7909f6@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/23 17:52:24, Christian Loehle wrote: > On 04/12/2023 17:22, Jorge Ramirez-Ortiz wrote: > > Requesting a retune before switching to the RPMB partition has been > > observed to cause CRC errors on the RPMB reads (-EILSEQ). > > > > Since RPMB reads can not be retried, the clients would be directly > > affected by the errors. > > > > This commit disables the request prior to RPMB switching while allowing > > the pause interface to still request a retune before the pause for other > > use cases. > > > > This was verified with the sdhci-of-arasan driver (ZynqMP) configured > > for HS200 using two separate eMMC cards (DG4064 and 064GB2). In both > > cases, the error was easy to reproduce triggering every few tenths of > > reads. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > Acked-by: Avri Altman > > Is the difference between this mail and the previous one just Avri's Ack? > No need to resend for every tag you receive. oops, every project with its own little idiosyncrasies sometimes I get confused (u-boot, optee, ssl, tf-a..) yes, sorry about it, no differences.