From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Angel Iglesias <ang.iglesiasg@gmail.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Andreas Klinger <ak@it-klinger.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series
Date: Mon, 4 Dec 2023 23:09:16 +0200 [thread overview]
Message-ID: <ZW4__HBfiJtwNF_p@smile.fi.intel.com> (raw)
In-Reply-To: <ZW4_OoyKSZ3EBL2x@smile.fi.intel.com>
On Mon, Dec 04, 2023 at 11:06:03PM +0200, Andy Shevchenko wrote:
> On Mon, Dec 04, 2023 at 09:43:59PM +0200, Petre Rodan wrote:
...
> > + ret = match_string(hsc_triplet_variants, HSC_VARIANTS_MAX,
> > + triplet);
> > + if (ret < 0)
> > + return dev_err_probe(dev, -EINVAL,
> > + "honeywell,pressure-triplet is invalid\n");
>
> Still you can use mentioned device property API.
Repeating here from v7 thread: I think that deduplicating code, esp. when APIs
are available, is a good to have before merging.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-04 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 19:43 [PATCH v7 1/2] dt-bindings: iio: pressure: add honeywell,hsc030 Petre Rodan
2023-12-04 19:43 ` [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series Petre Rodan
2023-12-04 21:06 ` Andy Shevchenko
2023-12-04 21:09 ` Andy Shevchenko [this message]
2023-12-06 17:45 ` Jonathan Cameron
2023-12-06 17:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW4__HBfiJtwNF_p@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@it-klinger.de \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox