From: Ashok Raj <ashok.raj@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"ashok_raj@linux.intel.com" <ashok_raj@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 1/3] hwmon: (coretemp) Introduce enum for attr index
Date: Tue, 5 Dec 2023 11:20:24 -0800 [thread overview]
Message-ID: <ZW93+OhBNRB+T/EM@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <a67fdc5ff2401519b99479c1b487b16c707ce0da.camel@intel.com>
On Fri, Dec 01, 2023 at 09:29:24AM -0800, Zhang, Rui wrote:
[snip]
> >
> > How about
> >
> > ATTR_LABEL,
> > ATTR_CRIT_ALARM,
> > ATTR_TEMP,
> > ATTR_TJMAX,
> > MAX_CORE_ATTRS, /* One more than TJMAX */
> > ATTR_TTARGET = MAX_CORE_ATTRS,
> > TOTAL_ATTRS
> >
> > Each enum can be assigned any value, but this way they are just
> > increasing
> > order.
>
> ATTR_TTARGET is the next attribute after ATTR_TJMAX so it should be
> right after ATTR_TJMAX.
> MAX_CORE_ATTRS is the number of basic attributes so it should be
> ATTR_TJMAX + 1.
> TOTAL_ATTRS is the number of possible attributes so it should be
> ATTR_TTARGET + 1
>
> ATTR_LABEL, // 0
> ATTR_CRIT_ALARM, // 1
> ATTR_TEMP, // 2
> ATTR_TJMAX, // 3
> ATTR_TTARGET, // 4
> MAX_CORE_ATTRS = ATTR_TJMAX + 1, // 4
> TOTAL_ATTRS = ATTR_TTARGET + 1, // 5
>
> How about this one?
Sorry for the delay... yes, this sounds fine.
next prev parent reply other threads:[~2023-12-05 19:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 13:16 [PATCH 0/3] hwmon: (coretemp) Fix core count limitation Zhang Rui
2023-11-27 13:16 ` [PATCH 1/3] hwmon: (coretemp) Introduce enum for attr index Zhang Rui
2023-11-30 21:51 ` Ashok Raj
2023-12-01 4:14 ` Guenter Roeck
2023-12-01 4:47 ` Ashok Raj
2023-12-01 17:29 ` Zhang, Rui
2023-12-05 19:20 ` Ashok Raj [this message]
2023-11-27 13:16 ` [PATCH 2/3] hwmon: (coretemp) Remove unnecessary dependency of array index Zhang Rui
2023-12-01 1:27 ` Ashok Raj
2023-12-01 3:26 ` Guenter Roeck
2023-12-01 4:34 ` Ashok Raj
2023-12-01 17:31 ` Zhang, Rui
2023-11-27 13:16 ` [PATCH 3/3] hwmon: (coretemp) Fix core count limitation Zhang Rui
2023-12-01 2:08 ` Ashok Raj
2023-12-01 17:47 ` Zhang, Rui
2023-12-01 22:58 ` Ashok Raj
2023-12-02 7:22 ` Zhang, Rui
2023-12-01 3:06 ` Guenter Roeck
2023-12-01 17:41 ` Zhang, Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW93+OhBNRB+T/EM@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=ashok_raj@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox