Re: [PATCH RFC 09/12] mm/gup: Handle huge pud for follow_pud_mask()

Christoph Hellwig
2023-11-23T07:28:39Z

> We need to export "struct follow_page_context" along the way, so that
> huge_memory.c can understand it.

Again, thankfully not actually exported, just made global.

> @@ -751,24 +746,25 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
> unsigned int flags,
> struct follow_page_context *ctx)
> {
> - pud_t *pud;
> + pud_t *pudp, pud;

This adding of pud while useful seems mostly unrelated and clutter
the patch up quite a bit. If you have to respin this anyway it might
be worth to split it out into a little prep patch.