From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDCECC4167B for ; Sun, 26 Nov 2023 17:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbjKZRA2 (ORCPT ); Sun, 26 Nov 2023 12:00:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKZRA0 (ORCPT ); Sun, 26 Nov 2023 12:00:26 -0500 X-Greylist: delayed 366 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 26 Nov 2023 09:00:31 PST Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [IPv6:2001:41d0:203:375::ac]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA85CFC for ; Sun, 26 Nov 2023 09:00:31 -0800 (PST) Date: Sun, 26 Nov 2023 12:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rosenzweig.io; s=key1; t=1701017661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZAmJjrTeu7RdpM+b+JpbyW5DOb3ge7UnfELqR9X21vo=; b=wtKzHquY9kuLOewD37q4BwVrha6NkJj6WgOHRMW2fatDWrh95MB18j0uarel5fLWSUlwzm qMFnbyvDB/aofTADTJ/nlhFvUuQllx8s/wZampc23S0zO6pAPeakTYc2B72HvYNGO0ViZj ZmTQ56CtscqX2ywNCKwpNtBVW1BgBeWIle2yzRtaYZKzXdq24efeXVX9GmJhOG2xoixOzh DimbDLLlpYvGnSBjMNL0rSQqoGv07vao0UMgEopo43J6LvDeCyvYPBrp7gTcbarL4bdbDN TgHm6XFBme6tpkYZ9h6dMbGtwAGPEDCLLWRg4CxtmbklMpqA5AXPGobkAlsKRw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Alyssa Rosenzweig To: Sven Peter Cc: Hector Martin , Joerg Roedel , Will Deacon , Robin Murphy , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: dart: Use readl instead of readl_relaxed for consistency Message-ID: References: <20231126162009.17934-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126162009.17934-1-sven@svenpeter.dev> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org r-b On Sun, Nov 26, 2023 at 05:20:09PM +0100, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c > index 59cf256bf40f..c7f047ce0a7a 100644 > --- a/drivers/iommu/apple-dart.c > +++ b/drivers/iommu/apple-dart.c > @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) > unsigned int sid, idx; > > for (sid = 0; sid < dart->num_streams; sid++) { > - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); > + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); > for (idx = 0; idx < dart->hw->ttbr_count; idx++) > dart->save_ttbr[sid][idx] = > readl(dart->regs + DART_TTBR(dart, sid, idx)); > -- > 2.34.1 >