* [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
@ 2023-11-27 2:07 Huang Shijie
2023-11-27 2:51 ` Baoquan He
2023-12-21 4:12 ` Baoquan He
0 siblings, 2 replies; 9+ messages in thread
From: Huang Shijie @ 2023-11-27 2:07 UTC (permalink / raw)
To: bhe; +Cc: vgoyal, dyoung, kexec, linux-kernel, patches, Huang Shijie
In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
and kernel will not use the "classic sparse" to do the
__pfn_to_page/page_to_pfn.
So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
This makes the user applications (crash, etc) get faster
pfn_to_page/page_to_pfn operations too.
Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
---
kernel/crash_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index efe87d501c8c..9653c4177191 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -765,6 +765,9 @@ static int __init crash_save_vmcoreinfo_init(void)
VMCOREINFO_SYMBOL(mem_map);
VMCOREINFO_SYMBOL(contig_page_data);
#endif
+#ifdef CONFIG_SPARSEMEM_VMEMMAP
+ VMCOREINFO_SYMBOL_ARRAY(vmemmap);
+#endif
#ifdef CONFIG_SPARSEMEM
VMCOREINFO_SYMBOL_ARRAY(mem_section);
VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS);
--
2.40.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-27 2:07 [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled Huang Shijie
@ 2023-11-27 2:51 ` Baoquan He
2023-11-27 3:18 ` Shijie Huang
2023-12-21 4:12 ` Baoquan He
1 sibling, 1 reply; 9+ messages in thread
From: Baoquan He @ 2023-11-27 2:51 UTC (permalink / raw)
To: Huang Shijie
Cc: k-hagio-ab, lijiang, akpm, vgoyal, dyoung, kexec, linux-kernel,
patches
Hi,
On 11/27/23 at 10:07am, Huang Shijie wrote:
> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
> and kernel will not use the "classic sparse" to do the
> __pfn_to_page/page_to_pfn.
>
> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
> This makes the user applications (crash, etc) get faster
> pfn_to_page/page_to_pfn operations too.
Are there Crash or makedupfile patches posted yet to make use of this?
>
> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
> ---
> kernel/crash_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index efe87d501c8c..9653c4177191 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -765,6 +765,9 @@ static int __init crash_save_vmcoreinfo_init(void)
> VMCOREINFO_SYMBOL(mem_map);
> VMCOREINFO_SYMBOL(contig_page_data);
> #endif
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> + VMCOREINFO_SYMBOL_ARRAY(vmemmap);
> +#endif
> #ifdef CONFIG_SPARSEMEM
> VMCOREINFO_SYMBOL_ARRAY(mem_section);
> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS);
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-27 2:51 ` Baoquan He
@ 2023-11-27 3:18 ` Shijie Huang
2023-11-28 3:25 ` Baoquan He
0 siblings, 1 reply; 9+ messages in thread
From: Shijie Huang @ 2023-11-27 3:18 UTC (permalink / raw)
To: Baoquan He, Huang Shijie
Cc: k-hagio-ab, lijiang, akpm, vgoyal, dyoung, kexec, linux-kernel,
patches
在 2023/11/27 10:51, Baoquan He 写道:
> Hi,
>
> On 11/27/23 at 10:07am, Huang Shijie wrote:
>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>> and kernel will not use the "classic sparse" to do the
>> __pfn_to_page/page_to_pfn.
>>
>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>> This makes the user applications (crash, etc) get faster
>> pfn_to_page/page_to_pfn operations too.
> Are there Crash or makedupfile patches posted yet to make use of this?
I have patches for Crash to use the 'vmemmap', but after this patch is
merged, I will send it out.
(I think Kazu will not merge a crash patch which depends on a kernel
patch which is not merged.)
Thanks
Huang Shijie
>> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
>> ---
>> kernel/crash_core.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
>> index efe87d501c8c..9653c4177191 100644
>> --- a/kernel/crash_core.c
>> +++ b/kernel/crash_core.c
>> @@ -765,6 +765,9 @@ static int __init crash_save_vmcoreinfo_init(void)
>> VMCOREINFO_SYMBOL(mem_map);
>> VMCOREINFO_SYMBOL(contig_page_data);
>> #endif
>> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> + VMCOREINFO_SYMBOL_ARRAY(vmemmap);
>> +#endif
>> #ifdef CONFIG_SPARSEMEM
>> VMCOREINFO_SYMBOL_ARRAY(mem_section);
>> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS);
>> --
>> 2.40.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-27 3:18 ` Shijie Huang
@ 2023-11-28 3:25 ` Baoquan He
2023-11-28 3:31 ` Shijie Huang
0 siblings, 1 reply; 9+ messages in thread
From: Baoquan He @ 2023-11-28 3:25 UTC (permalink / raw)
To: Shijie Huang
Cc: Huang Shijie, k-hagio-ab, lijiang, akpm, vgoyal, dyoung, kexec,
linux-kernel, patches
On 11/27/23 at 11:18am, Shijie Huang wrote:
>
> 在 2023/11/27 10:51, Baoquan He 写道:
> > Hi,
> >
> > On 11/27/23 at 10:07am, Huang Shijie wrote:
> > > In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
> > > kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
> > > and kernel will not use the "classic sparse" to do the
> > > __pfn_to_page/page_to_pfn.
> > >
> > > So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
> > > This makes the user applications (crash, etc) get faster
> > > pfn_to_page/page_to_pfn operations too.
> > Are there Crash or makedupfile patches posted yet to make use of this?
>
> I have patches for Crash to use the 'vmemmap', but after this patch is
> merged, I will send it out.
>
> (I think Kazu will not merge a crash patch which depends on a kernel patch
> which is not merged.)
Maybe post these userspace patches too so that Kazu can evaluat if those
improvement is necessary?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-28 3:25 ` Baoquan He
@ 2023-11-28 3:31 ` Shijie Huang
2023-11-28 7:34 ` Baoquan He
0 siblings, 1 reply; 9+ messages in thread
From: Shijie Huang @ 2023-11-28 3:31 UTC (permalink / raw)
To: Baoquan He
Cc: Huang Shijie, k-hagio-ab, lijiang, akpm, vgoyal, dyoung, kexec,
linux-kernel, patches
在 2023/11/28 11:25, Baoquan He 写道:
> On 11/27/23 at 11:18am, Shijie Huang wrote:
>> 在 2023/11/27 10:51, Baoquan He 写道:
>>> Hi,
>>>
>>> On 11/27/23 at 10:07am, Huang Shijie wrote:
>>>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>>>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>>>> and kernel will not use the "classic sparse" to do the
>>>> __pfn_to_page/page_to_pfn.
>>>>
>>>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>>>> This makes the user applications (crash, etc) get faster
>>>> pfn_to_page/page_to_pfn operations too.
>>> Are there Crash or makedupfile patches posted yet to make use of this?
>> I have patches for Crash to use the 'vmemmap', but after this patch is
>> merged, I will send it out.
>>
>> (I think Kazu will not merge a crash patch which depends on a kernel patch
>> which is not merged.)
> Maybe post these userspace patches too so that Kazu can evaluat if those
> improvement is necessary?
No problem. I will send out them later.
Thanks
Huang Shijie
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-28 3:31 ` Shijie Huang
@ 2023-11-28 7:34 ` Baoquan He
2023-12-21 3:11 ` Shijie Huang
0 siblings, 1 reply; 9+ messages in thread
From: Baoquan He @ 2023-11-28 7:34 UTC (permalink / raw)
To: Shijie Huang, k-hagio-ab
Cc: Huang Shijie, lijiang, akpm, vgoyal, dyoung, kexec, linux-kernel,
patches
On 11/28/23 at 11:31am, Shijie Huang wrote:
>
> 在 2023/11/28 11:25, Baoquan He 写道:
> > On 11/27/23 at 11:18am, Shijie Huang wrote:
> > > 在 2023/11/27 10:51, Baoquan He 写道:
> > > > Hi,
> > > >
> > > > On 11/27/23 at 10:07am, Huang Shijie wrote:
> > > > > In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
> > > > > kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
> > > > > and kernel will not use the "classic sparse" to do the
> > > > > __pfn_to_page/page_to_pfn.
> > > > >
> > > > > So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
> > > > > This makes the user applications (crash, etc) get faster
> > > > > pfn_to_page/page_to_pfn operations too.
> > > > Are there Crash or makedupfile patches posted yet to make use of this?
> > > I have patches for Crash to use the 'vmemmap', but after this patch is
> > > merged, I will send it out.
> > >
> > > (I think Kazu will not merge a crash patch which depends on a kernel patch
> > > which is not merged.)
> > Maybe post these userspace patches too so that Kazu can evaluat if those
> > improvement is necessary?
>
> No problem. I will send out them later.
Thank, Shijie. Let's wait and see if Kazu has any comment about these.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-28 7:34 ` Baoquan He
@ 2023-12-21 3:11 ` Shijie Huang
0 siblings, 0 replies; 9+ messages in thread
From: Shijie Huang @ 2023-12-21 3:11 UTC (permalink / raw)
To: Baoquan He, k-hagio-ab
Cc: Huang Shijie, lijiang, akpm, vgoyal, dyoung, kexec, linux-kernel,
patches
Hi Baoquan,
在 2023/11/28 15:34, Baoquan He 写道:
> On 11/28/23 at 11:31am, Shijie Huang wrote:
>> 在 2023/11/28 11:25, Baoquan He 写道:
>>> On 11/27/23 at 11:18am, Shijie Huang wrote:
>>>> 在 2023/11/27 10:51, Baoquan He 写道:
>>>>> Hi,
>>>>>
>>>>> On 11/27/23 at 10:07am, Huang Shijie wrote:
>>>>>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>>>>>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>>>>>> and kernel will not use the "classic sparse" to do the
>>>>>> __pfn_to_page/page_to_pfn.
>>>>>>
>>>>>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>>>>>> This makes the user applications (crash, etc) get faster
>>>>>> pfn_to_page/page_to_pfn operations too.
>>>>> Are there Crash or makedupfile patches posted yet to make use of this?
>>>> I have patches for Crash to use the 'vmemmap', but after this patch is
>>>> merged, I will send it out.
>>>>
>>>> (I think Kazu will not merge a crash patch which depends on a kernel patch
>>>> which is not merged.)
>>> Maybe post these userspace patches too so that Kazu can evaluat if those
>>> improvement is necessary?
>> No problem. I will send out them later.
> Thank, Shijie. Let's wait and see if Kazu has any comment about these.
Kazu is waiting for this patch to be merged now:
https://lists.crash-utility.osci.io/archives/list/devel@lists.crash-utility.osci.io/thread/IJB54DIDWEJVCSCOLDYLC5NJ5AUIJZDP/
Thanks
Huang Shijie
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-11-27 2:07 [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled Huang Shijie
2023-11-27 2:51 ` Baoquan He
@ 2023-12-21 4:12 ` Baoquan He
2024-01-17 1:32 ` Shijie Huang
1 sibling, 1 reply; 9+ messages in thread
From: Baoquan He @ 2023-12-21 4:12 UTC (permalink / raw)
To: Huang Shijie; +Cc: vgoyal, dyoung, kexec, linux-kernel, patches
On 11/27/23 at 10:07am, Huang Shijie wrote:
> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
> and kernel will not use the "classic sparse" to do the
> __pfn_to_page/page_to_pfn.
>
> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
> This makes the user applications (crash, etc) get faster
> pfn_to_page/page_to_pfn operations too.
>
> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
> ---
> kernel/crash_core.c | 3 +++
> 1 file changed, 3 insertions(+)
Ack this one as it's needed by crash utility patches.
Acked-by: Baoquan He <bhe@redhat.com>
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index efe87d501c8c..9653c4177191 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -765,6 +765,9 @@ static int __init crash_save_vmcoreinfo_init(void)
> VMCOREINFO_SYMBOL(mem_map);
> VMCOREINFO_SYMBOL(contig_page_data);
> #endif
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> + VMCOREINFO_SYMBOL_ARRAY(vmemmap);
> +#endif
> #ifdef CONFIG_SPARSEMEM
> VMCOREINFO_SYMBOL_ARRAY(mem_section);
> VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS);
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled
2023-12-21 4:12 ` Baoquan He
@ 2024-01-17 1:32 ` Shijie Huang
0 siblings, 0 replies; 9+ messages in thread
From: Shijie Huang @ 2024-01-17 1:32 UTC (permalink / raw)
To: Baoquan He, Huang Shijie, akpm
Cc: vgoyal, dyoung, kexec, linux-kernel, patches
Hi Andrew,
在 2023/12/21 12:12, Baoquan He 写道:
> On 11/27/23 at 10:07am, Huang Shijie wrote:
>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>> and kernel will not use the "classic sparse" to do the
>> __pfn_to_page/page_to_pfn.
>>
>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>> This makes the user applications (crash, etc) get faster
>> pfn_to_page/page_to_pfn operations too.
>>
>> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
>> ---
>> kernel/crash_core.c | 3 +++
>> 1 file changed, 3 insertions(+)
> Ack this one as it's needed by crash utility patches.
>
> Acked-by: Baoquan He <bhe@redhat.com>
Could you please merge this patch?
Thanks
Huang Shijie
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-01-17 1:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-27 2:07 [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP is enabled Huang Shijie
2023-11-27 2:51 ` Baoquan He
2023-11-27 3:18 ` Shijie Huang
2023-11-28 3:25 ` Baoquan He
2023-11-28 3:31 ` Shijie Huang
2023-11-28 7:34 ` Baoquan He
2023-12-21 3:11 ` Shijie Huang
2023-12-21 4:12 ` Baoquan He
2024-01-17 1:32 ` Shijie Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox