From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF20C4167B for ; Mon, 27 Nov 2023 08:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232640AbjK0IeH (ORCPT ); Mon, 27 Nov 2023 03:34:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbjK0IeF (ORCPT ); Mon, 27 Nov 2023 03:34:05 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5BD0A8 for ; Mon, 27 Nov 2023 00:34:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804CDC433C7; Mon, 27 Nov 2023 08:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701074051; bh=unCaXJLxTUPj78Mw3wAj0N85QPztmDRO+DsnNzOcHyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eeGLYqfHsnH5C6JZJowFVGo9N5tWStKUX+kM+DtxMi7feq8XDRqdrh5Kd71O7SOPv jcXSPKwkVBN/lTBdh6MAQMaoP9XelvBzA8LyL+R20UoV6Cs+fLQO7ldHpTAiHQA58e aZ+E4v/P+v+uD7kviN+GaxpOjy0gCd7+itWbRKSkjjUrYnLgBgqYUZoNrlpdB4+p88 ILOrEGU5g+6zjXMkhdBNzJ4DqEkYDEoVvu93RwXhbsXevJu2Mj21tpj1itZ59FcsqV he+pXIMym5Br9bRJdUZtYR3TuJET+EoeXlw16FnAF93Y996DFyICivSTRIH6uL3QBU Ys7Jt98Wddt+w== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r7X4f-0002ln-0B; Mon, 27 Nov 2023 09:34:37 +0100 Date: Mon, 27 Nov 2023 09:34:37 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [RFC PATCH 0/2] ASoC: soc-dai: add flag to mute and unmute stream during trigger. Message-ID: References: <20231027105747.32450-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 27, 2023 at 01:52:11PM +0200, Johan Hovold wrote: > On Fri, Oct 27, 2023 at 11:57:45AM +0100, Srinivas Kandagatla wrote: > > Click/Pop Noise was a long pending issue with WSA Codecs which are prone > > to accumlate DC when ports are active but without any data streams. > > There are multiple places in the current setup, where this could happen > > in both startup as well as shutdown path. > > > > This patchset adds a new flag mute_unmute_on_trigger to dai_ops to let > > generic code do the mute/unmute on trigger. > > > > This patches help fix those issues by making sure the PA is Muted/Unmuted > > inline with the stream start/stop events. > > > > Srinivas Kandagatla (2): > > ASoC: soc-dai: add flag to mute and unmute stream during trigger > > ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag > > I've verified that this fixes the pop sounds when starting and stopping > a stream on the X13s, even if the click sound when killing pulseaudio > (e.g. on reboot) is still there (as with the previous fixes). For the record, the remaining click sounds were incidentally fixed by commit 3efcb471f871 ("ASoC: soc-pcm.c: Make sure DAI parameters cleared if the DAI becomes inactive") which also went into 6.7-rc1: https://lore.kernel.org/lkml/20230920153621.711373-1-chancel.liu@nxp.com/ Johan