From: Jisheng Zhang <jszhang@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Expand led_colors[] array
Date: Mon, 27 Nov 2023 23:59:13 +0800 [thread overview]
Message-ID: <ZWS80c/ZQvaGIM96@xhacker> (raw)
In-Reply-To: <20231123105620.GG1184245@google.com>
On Thu, Nov 23, 2023 at 10:56:20AM +0000, Lee Jones wrote:
> On Mon, 30 Oct 2023, Jisheng Zhang wrote:
>
> > commit 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID
> > definitions") expands LED_COLOR_ID definitions for dt-binding. However,
> > it doesn't expand the led_colors[] array in leds core, so if any of
> > the newly expaned LED_COLOR_ID definitions is used, the sysfs will
> > emit null in the led's name color part. Let's expand the led_colors[]
> > array too.
> >
> > Before the commit:
> > /sys/class/leds # ls
> > (null):indicator-0
> >
> > After the commit:
> > /sys/class/leds # ls
> > orange:indicator-0
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > drivers/leds/led-core.c | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> This already exists as:
>
> a067943129b4e leds: core: Add more colors from DT bindings to led_colors
well, my patch was sent earlier than this one... When I sent out the
patch there's neither fix in mailist nor in your repo.
next prev parent reply other threads:[~2023-11-27 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 5:47 [PATCH] leds: Expand led_colors[] array Jisheng Zhang
2023-11-23 10:56 ` Lee Jones
2023-11-27 15:59 ` Jisheng Zhang [this message]
2023-11-30 11:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWS80c/ZQvaGIM96@xhacker \
--to=jszhang@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).