From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E740C4167B for ; Mon, 27 Nov 2023 13:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbjK0NUt (ORCPT ); Mon, 27 Nov 2023 08:20:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233588AbjK0NUo (ORCPT ); Mon, 27 Nov 2023 08:20:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B77F61A2 for ; Mon, 27 Nov 2023 05:20:50 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33E4DC433C7; Mon, 27 Nov 2023 13:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701091250; bh=BM2l69clFzuDzEVVhytXVUK2DJxV/0d206kvjSJINks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xv0EazDbL5w497ShYfaO6O4fNO3gSTJkF2A2hgKPWQvK3qdpYmsJBsPkoINsEVvDi CmZb57F8xzqqTfBqUeHF/evGsAj0Y9zXPXXDE799sfWDaZJM8JRhX6/EDsTaBxfjaT 0FiasSKE2LFArvU2OnBbPgxrLs1zO0Sa1E9Mdmg8LjqUpYxlqwOHUQ1sDxISrZXaAa YQTR2jYSaHBQySKthYmKSchxflkzdf0RAzONuHRUkAT8iv1VGh6QZD/hJq0W81H6U7 lcW/TQH4Ne4uDhHoAt+qjCyZL2QWhSE7gLOC6tNnaSbCioO8HyVz9kEXSzGrTTb+3W J/izWbOrAq8sw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id E5A3940094; Mon, 27 Nov 2023 10:20:47 -0300 (-03) Date: Mon, 27 Nov 2023 10:20:47 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Nick Forrington , Michael Petlan , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Arnaldo Carvalho de Melo , vmolnaro@redhat.com Subject: Re: [PATCH] perf test: Remove atomics from test_loop to avoid test failures Message-ID: References: <20231102162225.50028-1-nick.forrington@arm.com> <20231125030529.GB178091@leoy-huanghe> <20231126074030.GA647134@leoy-yangtze.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231126074030.GA647134@leoy-yangtze.lan> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Nov 26, 2023 at 03:41:14PM +0800, Leo Yan escreveu: > Maybe the commit log caused a bit confusion, the problem is after We'll have the Link pointing to this discussion. > enabling "-moutline-atomics" on aarch64, the overhead is altered into > the linked __aarch64_ldadd4_relax() function, test_loop() cannot be > sampled anymore, but it's not about stack tracing. > > Anyway, the patch is fine for me. I'm taking this as an Acked-by: Leo But probably this could be even a Tested-by, ok? - Arnaldo