From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD8AAC46CA0 for ; Mon, 27 Nov 2023 13:22:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbjK0NWd (ORCPT ); Mon, 27 Nov 2023 08:22:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233286AbjK0NW2 (ORCPT ); Mon, 27 Nov 2023 08:22:28 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 155C81BD for ; Mon, 27 Nov 2023 05:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701091353; x=1732627353; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kzVK6/8jtEngesohNvB3UsJNfu2VDm6OVryNzNnZYz0=; b=ZEThBOnS4HC5iuGwnx4Q+lq77M/bTdFkOPunC7l0xFLjobqBoBBf/74k 6z82vcpXtbnAh8IjVphpK9KOpO62W86C2BD6diTkGujFYDAyLhXNlpgUG lfv3GzkF8I4cRl4TTaGL3p/4Kla2qRHa4yWeIbw4QtdDSwMoe2gZsTdzQ wZHJdKu2ZhFlvTE18wo7Kwaj61Yp3KCc23xl3fFLNXcELooTg4mlKd+o7 YIEJMW+BCQoDPoutUt3zeBLzgEUsXsQSUDS/EkBNmiI671kSqoFWfGA3R knRfEZ6+gVPY/PQ6EwFmR1TlboFUc6AUpiqM4Gm3su3tO/SqjagfZRrA8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="392448044" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="392448044" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2023 05:22:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10906"; a="761600159" X-IronPort-AV: E=Sophos;i="6.04,230,1695711600"; d="scan'208";a="761600159" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga007.jf.intel.com with SMTP; 27 Nov 2023 05:22:29 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 27 Nov 2023 15:22:29 +0200 Date: Mon, 27 Nov 2023 15:22:29 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Winkler, Tomas" Cc: "Teres Alexis, Alan Previn" , "gregkh@linuxfoundation.org" , "intel-gfx@lists.freedesktop.org" , "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" , "Lubart, Vitaly" Subject: Re: [Intel-gfx] [char-misc-next 3/4] mei: pxp: re-enable client on errors Message-ID: References: <20231011110157.247552-1-tomas.winkler@intel.com> <20231011110157.247552-4-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 15, 2023 at 10:35:16PM +0200, Ville Syrjälä wrote: > On Tue, Nov 14, 2023 at 06:40:26PM +0000, Winkler, Tomas wrote: > > > > > > > -----Original Message----- > > > From: Teres Alexis, Alan Previn > > > Sent: Tuesday, November 14, 2023 5:32 PM > > > To: ville.syrjala@linux.intel.com; Winkler, Tomas > > > Cc: gregkh@linuxfoundation.org; Usyskin, Alexander > > > ; linux-kernel@vger.kernel.org; intel- > > > gfx@lists.freedesktop.org; Lubart, Vitaly > > > Subject: Re: [char-misc-next 3/4] mei: pxp: re-enable client on errors > > > > > > On Tue, 2023-11-14 at 16:00 +0200, Ville Syrjälä wrote: > > > > On Wed, Oct 11, 2023 at 02:01:56PM +0300, Tomas Winkler wrote: > > > > > From: Alexander Usyskin > > > > > > > > > > Disable and enable mei-pxp client on errors to clean the internal state. > > > > > > > > This broke i915 on my Alderlake-P laptop. > > > > This fix was already posted, just missed the merging window > > https://lkml.org/lkml/2023/10/31/636 > > Gave this a spin and it fixes the issue for me. Thanks. > > > > > Greg can you please take this fix into v6.7-rc2 run, or I can repost it with the correct subject. We're at -rc3 already and this fix is still not in! > > Thanks > > Tomas > > > > > > > > > > > > > > > > > Hi Alex, i just relooked at the series that got merged, and i noticed that in patch > > > #3 of the series, you had changed mei_pxp_send_message to return bytes sent > > > instead of zero on success. IIRC, we had agreed to not effect the behavior of > > > this component interface (other than adding the timeout) - this was the > > > intention of Patch #4 that i was pushing for in order to spec the interface > > > (which continues to say zero on success). We should fix this to stay with the > > > original behavior - where mei-pxp should NOT send partial packets and will > > > only return zero in success case where success is sending of the complete > > > packets - so we don't need to get back the "bytes sent" > > > from mei_pxp_send_message. So i think this might be causing the problem. > > > > > > > > > Side note to Ville:, are you enabling PXP kernel config by default in all MESA > > > contexts? I recall that MESA folks were running some CI testing with enable > > > pxp contexts, but didn't realize this is being enabled by default in all contexts. > > > Please be aware that enabling pxp-contexts would temporarily disabled > > > runtime-pm during that contexts lifetime. > > > Also pxp contexts will be forced to be irrecoverable if it ever hangs. > > > The former is a hardware architecture requirement but doesn't do anything if > > > you're enabling display (which I beleive also blocks in ADL). The latter was a > > > requirement to comply with Vulkan. > > > > > > ...alan > > > > > > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel