From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CD4C4167B for ; Mon, 27 Nov 2023 14:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233690AbjK0OnD (ORCPT ); Mon, 27 Nov 2023 09:43:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233680AbjK0OnA (ORCPT ); Mon, 27 Nov 2023 09:43:00 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61AC1135 for ; Mon, 27 Nov 2023 06:43:06 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D00C3C433C9; Mon, 27 Nov 2023 14:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701096186; bh=Mpooaxd6qlzBPGhMTWc6TBoY3fAhwP8179zOVmhHZc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C0VNXQBwfae+zomFI11MW8jQNo54Ite29pj5VueZhibOsECkW6sXOwK6tXfRNQP39 +IANnpFjvNm7rfjHrm5isjxt0alRAe6nU/iHbwgglaLhKcvRfsc0+SG/ZiQlfwrC4k uFJ93bmvs3WS7htUoE6m0HcGEJ++rLv62oBk9t5FENgZX4ynbmk2ALPVALcsQzL4KY IydyWZQQ0ULedy1YINLzCUgNShE96xrcq7pjdmJFBqGtqCOEk134V4yq3V7rIFZ4HR XWN03DeJB7jFFCfE/lXbBs13/O9H67frXJCL6GhMO1QQnFIFKPYhp3xupFRFTwEIyP 4ZZYC5W77KIcg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8094940094; Mon, 27 Nov 2023 11:43:03 -0300 (-03) Date: Mon, 27 Nov 2023 11:43:03 -0300 From: Arnaldo Carvalho de Melo To: Nick Forrington Cc: Namhyung Kim , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/2] perf lock info: Enforce exactly one of --map and --thread Message-ID: References: <20231031120526.11502-1-nick.forrington@arm.com> <20231031120526.11502-3-nick.forrington@arm.com> <3ae2cf90-b0a1-5f54-56aa-ed4a04dca8b0@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Nov 13, 2023 at 11:50:16AM +0000, Nick Forrington escreveu: > On 08/11/2023 20:28, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 01, 2023 at 11:00:42PM -0700, Namhyung Kim escreveu: > > > On Wed, Nov 1, 2023 at 7:35 AM Nick Forrington wrote: > > > > On 31/10/2023 15:38, Arnaldo Carvalho de Melo wrote: > > > > > Em Tue, Oct 31, 2023 at 12:05:25PM +0000, Nick Forrington escreveu: > > > > > > Improve error reporting for command line arguments. > > > > > > Display error/usage if neither --map or --thread are specified (rather > > > > > > than a non user-friendly error "Unknown type of information"). > > > > > > Display error/usage if both --map and --thread are specified (rather > > > > > > than ignoring "--map" and displaying only thread information). > > > > > Shouldn't one of them be the default so that we type less for the most > > > > > common usage? > > > > There isn't an obvious choice (to me) for which would be the default. > > > > Both options display completely different data/outputs, so I think it > > > > makes sense to be explicit about which data is requested. > > > Maybe we can default to display both. :) > > Yeah, that would be a better approach, I think. > I'll submit an updated series for this, with the next update to patch 1/2 Thanks, tried using b4 but it din't find a v2, will wait then. - Arnaldo