Re: [PATCH v2] pinctrl: samsung: add irq_set_affinity() for non wake up external gpio interrupt

Krzysztof Kozlowski
2023-11-27T09:59:22Z

On 26/11/2023 10:46, Youngmin Nam wrote:
> To support affinity setting for non wake up external gpio interrupt,
> add irq_set_affinity callback using irq number from pinctrl driver data.
>
> Before this patch, changing the irq affinity of gpio interrupt is not possible:
>
> # cat /proc/irq/418/smp_affinity
> 3ff
> # echo 00f > /proc/irq/418/smp_affinity

Does this command succeed on your board?

> # cat /proc/irq/418/smp_affinity
> 3ff
> # cat /proc/interrupts
> CPU0 CPU1 CPU2 CPU3 ...
> 418: 3631 0 0 0 ...
>
> With this patch applied, it's possible to change irq affinity of gpio interrupt:

...

On which board did you test it?

> + if (parent)
> + return parent->chip->irq_set_affinity(parent, dest, force);
> +

I think there is a helper for it: irq_chip_set_affinity_parent().

Best regards,
Krzysztof