Re: [PATCH v2] pinctrl: samsung: add irq_set_affinity() for non wake up external gpio interrupt

Youngmin Nam
2023-11-29T09:31:02Z

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

On Wed, Nov 29, 2023 at 09:39:45AM +0100, Krzysztof Kozlowski wrote:
> On 29/11/2023 09:46, Youngmin Nam wrote:
> >>> I couldn't find out a pin for the test on E850-96 board yet.
> >>> We can test if there is a usage of *Non" Wake up External Interrupt of GPIO
> >>> on E850-96 board.
> >>>
> >>> Do you have any idea ?
> >>
> >> Please test on any upstream platform or upstream your existing platform.
> >> I hesitate to take this change because I don't trust Samsung that this
> >> was tested on mainline kernel. OK, for sure 100% it was not tested on
> >> mainline, but I am afraid that differences were far beyond just missing
> >> platforms. Therefore the issue might or might not exist at all. Maybe
> >> issue is caused by other Samsung non-upstreamed code.
> >>
> >> Best regards,
> >> Krzysztof
> >
> > Sure. Let me find how to test on upstreamed device like E850-96 board.
>
> There are many reasons why companies using Linux for their products
> should be involved in upstreaming their devices.
>
> The one visible from this conversation: Whatever technical debt you
> have, it will be only growing because upstream might not even take
> simple patches from you, until you start contributing with the rest.
> Samsung's out-of-tree kernels are so far away from the upstream, that
> basically we might feel that contributions from Samsung are not
> addressing real problems. This will affect your Android trees due to GKI.
>
> That's one more argument to talk to with your managers why staying away
> from the upstream is not the best idea.
>
> Second argument is look at your competitor: Qualcomm, one of the most
> active upstreamers of SoC code doing awesome job.
>
> Best regards,
> Krzysztof

Thank you for your opinion.
By the way, this patch is not related with GKI and I just thought this work
would be helpful to all exynos platform.

But it seems that changing affinity of any irqs including gpio is not allowed
on exynos platform. So we need to debug by adding some logs.

>
>

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]